Skip to content

Conversation

@lahma
Copy link
Collaborator

@lahma lahma commented Jan 26, 2025

If someone would ever still need NET 6, they would just fall back to netstandard. Now cancelling old jobs for new pushes for same PR.

Copy link
Owner

@adams85 adams85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, as far as I can see, the only drawback of switching to netstandard2.1 for potential .NET 6 users would be losing this optimization:
https://github.com/adams85/acornima/blob/v1.1.1/src/Acornima/Tokenizer.RegExpParser.cs#L1077-L1082

Which is not a big deal, so I'm ok with dropping net6.0.

However, it would be nice to run tests on net9.0 as well. Could you possibly set up NUKE to do this?

@lahma lahma force-pushed the update-deps branch 3 times, most recently from bf14fcb to 0f75a1d Compare January 31, 2025 17:46
@lahma
Copy link
Collaborator Author

lahma commented Jan 31, 2025

Well, as far as I can see, the only drawback of switching to netstandard2.1 for potential .NET 6 users would be losing this optimization: v1.1.1/src/Acornima/Tokenizer.RegExpParser.cs#L1077-L1082

I myself have a hard stance for modern NET, anyone who has jumped to this wagon is expected to upgrade their solutions, especially as it's quite easy from NET 5 onwards. Full framework support lifecycle is a different thing and this change does follow EOL.

However, it would be nice to run tests on net9.0 as well. Could you possibly set up NUKE to do this?

Sure thing! I added the the test project targets, no NUKE changes required as tests will be run on each targeted framework. You can see in the latest commit that I had to do some little adjustements.

@adams85
Copy link
Owner

adams85 commented Jan 31, 2025

I myself have a hard stance for modern NET, anyone who has jumped to this wagon is expected to upgrade their solutions, especially as it's quite easy from NET 5 onwards.

You're absolutely right, it's just that real life doesn't really want to follow this idea in my experience... 😄 Because of this, I usually don't care much about out-of-support targets until they become too painful.

But again, I'm completely happy if we move with the times in this project.

Sure thing! I added the the test project targets, no NUKE changes required as tests will be run on each targeted framework. You can see in the latest commit that I had to do some little adjustements.

Thank you very much!

@adams85 adams85 merged commit 4e9d1c5 into master Jan 31, 2025
3 checks passed
@adams85 adams85 deleted the update-deps branch January 31, 2025 19:29
@lahma lahma restored the update-deps branch January 31, 2025 19:42
@lahma lahma deleted the update-deps branch January 31, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants