Collaboration: Define WP_ALLOW_COLLABORATION inline#46
Closed
Collaboration: Define WP_ALLOW_COLLABORATION inline#46
Conversation
See #64713, #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61724 602fd350-edb4-49c9-b593-d223f7449a82
The relevant files will be scanned within `src` (provided the build script has been run). See #64394. git-svn-id: https://develop.svn.wordpress.org/trunk@61726 602fd350-edb4-49c9-b593-d223f7449a82
…()`. This reflects that the method can return both `true` (success) and `false` (failure). Follow-up to [32620], [34089], [44941]. Props huzaifaalmesbah, westonruter. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61727 602fd350-edb4-49c9-b593-d223f7449a82
Fix the icon alignment in the welcome panel close button following the admin reskin. Props mohitbsf, opurockey, huzaifaalmesbah, joedolson. Fixes #64681. git-svn-id: https://develop.svn.wordpress.org/trunk@61728 602fd350-edb4-49c9-b593-d223f7449a82
Following the admin reskin, the larger buttons in plugin cards caused an existing potential for text overlap to happen more easily. Switching to compact size restores prior behavior. Props hiroshisato, audrasjb, huzaifaalmesbah, shailu25, joedolson. Fixes #64686. git-svn-id: https://develop.svn.wordpress.org/trunk@61729 602fd350-edb4-49c9-b593-d223f7449a82
Following the admin reskin, the Copy link button for sharing customizer previews was misaligned. Override core button disabled styles to set transform and background properties. Fix shadow height. Props mohitbsf, audrasjb, hbhalodia, huzaifaalmesbah, sajib1223, joedolson. Fixes #64688. git-svn-id: https://develop.svn.wordpress.org/trunk@61730 602fd350-edb4-49c9-b593-d223f7449a82
This changeset backports the changes made to common notices to `login.css`. Props juanfra, huzaifaalmesbah, shailu25, joedolson. Fixes #64715. git-svn-id: https://develop.svn.wordpress.org/trunk@61731 602fd350-edb4-49c9-b593-d223f7449a82
…dget. This changeset standardizes the vertical spacing between the heading and the first content item in the “At a Glance” admin dashboard widget to match the spacing conventions used by other dashboard widgets. Props mohitbsf, opurockey, adnanhyder. Fixes #64682. git-svn-id: https://develop.svn.wordpress.org/trunk@61732 602fd350-edb4-49c9-b593-d223f7449a82
…velopment environment. The `wp_install_maybe_enable_pretty_permalinks()` function usually enables pretty permalinks during installation, but it relies on a loopback request that may not work on all development environments. In temporary lieu of fixing the underlying loopback request on all the container images, this switches to explictly enabling permalinks and removes redundant permalink configuration from GitHub Actions workflow files. See #64227 git-svn-id: https://develop.svn.wordpress.org/trunk@61733 602fd350-edb4-49c9-b593-d223f7449a82
Refines the Navigation Overlay template description to remove the "full-screen" assumption and clarify that the overlay can be toggled open and closed. Follow-up to [61609]. Props get_dave, scruffian, wildworks. See #64589. git-svn-id: https://develop.svn.wordpress.org/trunk@61734 602fd350-edb4-49c9-b593-d223f7449a82
This was previosly listed as defaulting to `false` when in fact it defaults to `true.` Developed in: WordPress#11022 Discussed in: https://core.trac.wordpress.org/ticket/64224 Reported in: WordPress/Documentation-Issue-Tracker#1849 Props dmsnell, noruzzaman, vHeemstra, westonruter. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61735 602fd350-edb4-49c9-b593-d223f7449a82
The admin reskin changed info notices to a transparent background, matching usage in Gutenberg. But with the gray background in the core admin, these notices didn't show up in an expected manner. Additionally, using a transparent background in a context where the background color is variable is risky for color contrast. Change `.notice-info`, `.notice-info.notice-alt`, and `.login .notice, .login .message` to use white backgrounds. Reverts changes from [61731] to apply styles also to `.message` class. Props mohitbsf, audrasjb, peterwilsoncc, pbiron, fabiankaegy, noruzzaman, joedolson. Fixes #64678. See #64715. git-svn-id: https://develop.svn.wordpress.org/trunk@61737 602fd350-edb4-49c9-b593-d223f7449a82
The `aria-label` on post titles in list tables changes the accessible name from `{post_title}` to `"{post_title}" (Edit)`. This change increases verbosity for screen readers and creates a mismatch between the visual text and the accessible name for voice command.
Remove the extraneous `aria-label`.
Props afercia, rianrietveld, iworks, muddassirnasim, joedolson.
Fixes #33002.
git-svn-id: https://develop.svn.wordpress.org/trunk@61738 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61674]. Props Soean, apermo. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61739 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61738]. Updates e2e tests to use new link name. Applies change to omitted case in term list tables. Props joedolson. Fixes #33002. git-svn-id: https://develop.svn.wordpress.org/trunk@61740 602fd350-edb4-49c9-b593-d223f7449a82
Plugin and theme installer buttons load a dashicon during their updating and updated states. These dashicons were sized to large buttons, and caused a shift in alignment after the switch to compact buttons. Update CSS to prevent shifts in size and alignment for installer buttons. Props mohitbsf, peterwilsoncc, adnanhyder, huzaifaalmesbah, noruzzaman, ravichudasama01, shailu25, r1k0, joedolson. Fixes #64687. git-svn-id: https://develop.svn.wordpress.org/trunk@61741 602fd350-edb4-49c9-b593-d223f7449a82
Fix the height, background, and positioning of the skip to editor link in the classic editor, to prevent overflow and override transparent background. Props sabernhardt, huzaifaalmesbah, joedolson. Fixes #64727. git-svn-id: https://develop.svn.wordpress.org/trunk@61742 602fd350-edb4-49c9-b593-d223f7449a82
Prevent the Twenty Twenty theme styles from overriding the Pullquote block's letter case settings. Props paragjethva, hiteshtalpada, shailu25, poena, mukesh27, sukhendu2002, dhruvang21, ugyensupport, darshitrajyaguru97, sabernhardt, r1k0, joedolson. Fixes #62773. git-svn-id: https://develop.svn.wordpress.org/trunk@61743 602fd350-edb4-49c9-b593-d223f7449a82
Adjust the line-height of the dashicon for the media panel mobile menu. Props huzaifaalmesbah, joedolson. Fixes #64726. git-svn-id: https://develop.svn.wordpress.org/trunk@61744 602fd350-edb4-49c9-b593-d223f7449a82
Remove the title attribute from `the_author_posts_link()` and related functions, retaining text for use in `the_author_posts_link` filter, and add parameter to disable title attributes in `the_author_link()`. Default behavior will still differentiate the two links, but adds the option to remove all title attributes. Props sabernhardt, alh0319, adnanlimdi, audrasjb, joedolson. Fixes #62835. See #26559. git-svn-id: https://develop.svn.wordpress.org/trunk@61745 602fd350-edb4-49c9-b593-d223f7449a82
… refreshing. Syncs PHP changes from WordPress/gutenberg#75883. Changes the real-time collaboration polling server endpoint to accept null for awareness values, which is used to explicitly disconnect users leaving the page and remove their awareness data more quickly. CI run: WordPress#11049. Fixes #64622. Props alecgeatches. git-svn-id: https://develop.svn.wordpress.org/trunk@61746 602fd350-edb4-49c9-b593-d223f7449a82
Ensures normalization preserves content in `PRE`, `LISTING`, and `TEXTAREA` elements. These elements ignore a single leading newline during parsing. Normalization now injects a newline after the tag opener to trigger this behavior, preventing significant newlines from being incorrectly stripped. Developed in WordPress#10871. Props jonsurrell, dmsnell, mukesh27. Fixes #64607. git-svn-id: https://develop.svn.wordpress.org/trunk@61747 602fd350-edb4-49c9-b593-d223f7449a82
Make it easier to iterate on this class in Gutenberg via class extension. See proof of concept and discussion in: WordPress/gutenberg#75878 Follow-up to [61674]. Props mcsf. See #64651. git-svn-id: https://develop.svn.wordpress.org/trunk@61748 602fd350-edb4-49c9-b593-d223f7449a82
Adds `wp-includes/connectors.php` (loaded from `wp-settings.php`) and registers a Settings > Connectors submenu when the AI client and Connectors admin page renderer are available. Registers connector API key settings in `/wp/v2/settings`, masks key values on option reads, validates keys against provider configuration, and returns `invalid_key` for explicitly requested connector fields when validation fails. Stored connector keys are also passed to the AI client registry on init. Gutenberg PR at WordPress/gutenberg#75833. Developed in WordPress#11056. Props jorgefilipecosta, gziolo, flixos90, justlevine, westonruter, jeffpaul, JasonTheAdams, audrasjb, shaunandrews, noruzzaman, mukesh27. Fixes #64730. git-svn-id: https://develop.svn.wordpress.org/trunk@61749 602fd350-edb4-49c9-b593-d223f7449a82
CI run: WordPress#11059. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 23b566c72e9c4a36219ef5d6e62890f05551f6cb..022d8dd3d461f91b15c1f0410649d3ebb027207f | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Pattern Editing: Fix nested patterns/sections (WordPress/gutenberg#75772) - QuickEdit: rename status label and remove extra labels in popup (WordPress/gutenberg#75824) - Fix block editing modes not recomputing when isolated editor value changes (WordPress/gutenberg#75821) - Synced patterns: Fix block editing mode of synced pattern content when nested in an unsynced pattern (WordPress/gutenberg#75818) - Block Support: Fix custom CSS not saved when style schema is not defined (WordPress/gutenberg#75797) - Gallery: Fixes keyboard focus escaping the lightbox overlay when navigating a gallery with Tab/Shift+Tab. (WordPress/gutenberg#75852) - Navigation Overlay Close: Set Close as default text, rather than using a placeholder (WordPress/gutenberg#75692) - RTC: Fix entity save call / initial persistence. (WordPress/gutenberg#75841) - Real-time collaboration: Improve collaboration within the same rich text (WordPress/gutenberg#75703) - Client Side Media: Add device/browser capability detection (WordPress/gutenberg#75863) - Navigation editing: simplify edit/view buttons (WordPress/gutenberg#75819) - Add core/icon block to theme.json schema (WordPress/gutenberg#75813) - Fix error when undoing newly added pattern (WordPress/gutenberg#75850) - Page List Item: Replace RawHTML with dangerouslySetInnerHTML for label and title (WordPress/gutenberg#75890) - REST API: Make filter_wp_unique_filename() static to match core, plus avoid duplicate routes (WordPress/gutenberg#75782) - RichText: useAnchor: Fix TypeError in virtual element (WordPress/gutenberg#75900) - DataViews: Remove menu divider again. (WordPress/gutenberg#75908) - Theme: Add build plugins to inject design token fallbacks (WordPress/gutenberg#75901) - Theme: Remove global stylesheet (WordPress/gutenberg#75879) - Real-time collaboration: Remove ghost awareness state explicitly when refreshing (WordPress/gutenberg#75883) - Real-time collaboration: Expand mergeCrdtBlocks() automated testing (WordPress/gutenberg#75923) - Fix client-side media file naming (WordPress/gutenberg#75817) - Add: Connectors screen (WordPress/gutenberg#75833) - Merge document meta into state map (WordPress/gutenberg#75830) - Move WordPress meta key from sync package to core-data (WordPress/gutenberg#75846) - Bugfix: Fix casing of getPersistedCRDTDoc (WordPress/gutenberg#75922) - Add debug logging to SyncManager (WordPress/gutenberg#75924) - DataForm: fix label colors (WordPress/gutenberg#75730) - DataViews: minimize padding for primary action buttons (WordPress/gutenberg#75721) (WordPress/gutenberg#75947) - Connectors: Add `_ai_` prefix to connector setting names and fix naming inconsistencies (WordPress/gutenberg#75948) - Connectors: Unhook Core callbacks in Gutenberg coexistence (WordPress/gutenberg#75935) - Unsynced patterns: Rename 'Disconnect pattern' to 'Detach pattern' in context menu (WordPress/gutenberg#75807) - Editor: Remove View dropdown and pinned items from revisions header (WordPress/gutenberg#75951) - Fix: Template revisions infinite spinner (WordPress/gutenberg#75953) - Backport: Avoid flickering while refreshing (WordPress/gutenberg#74572) (WordPress/gutenberg#75952) - Add wp_ prefix to real time collaberation option. (WordPress/gutenberg#75837) git-svn-id: https://develop.svn.wordpress.org/trunk@61750 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61751 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61752 602fd350-edb4-49c9-b593-d223f7449a82
…step1()`. This prevents the variables from being undefined when the condition isn't met. Follow-up to [56599]. Props huzaifaalmesbah, noruzzaman. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61753 602fd350-edb4-49c9-b593-d223f7449a82
HTML specifies that a single newline is ignored at the start of a `TEXTAREA`. If `::set_modifiable_text()` is called with a leading newline, ensure it is preserved in the resulting HTML. Developed in WordPress#11062. Props jonsurrell, dmsnell. See #64609. git-svn-id: https://develop.svn.wordpress.org/trunk@61754 602fd350-edb4-49c9-b593-d223f7449a82
When bookmark exhaustion occurs during processing, return `false` instead of throwing an `Exception`. Developed in WordPress#10616. Props jonsurrell, westonruter, dmsnell. Fixes #64394. git-svn-id: https://develop.svn.wordpress.org/trunk@61755 602fd350-edb4-49c9-b593-d223f7449a82
This removes a redundant ternary that no longer affects the logic after the `esc_url()` call on the tag URL was moved to the output in an earlier revision. Follow-up to [9518], [11383], [32996]. Props Soean. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62066 602fd350-edb4-49c9-b593-d223f7449a82
…ures. This includes a `WP_AI_SUPPORT` constant and a `wp_supports_ai` filter. When false, - `_wp_connectors_get_provider_settings()` will return an empty array (short-circuiting the other functionality). - `WP_AI_Client_Prompt_Builder()` will short-circuit the construction with a `WP_Error()`. `wp_ai_client_prompt()` will still return an instance, to allow for fluidity to remain intact. Priority: `WP_AI_SUPPORT` > `add_filter( 'wp_supports_ai', ...) > (default: true)` Follow-up to [61943], [61749], [61943]. Props justlevine, westonruter, gziolo, flixos90, romainmrhenry, ahortin, chrismcelroyseo, SergeyBiryukov. See #64706. git-svn-id: https://develop.svn.wordpress.org/trunk@62067 602fd350-edb4-49c9-b593-d223f7449a82
…s()`. Replace the previous generic concatenation logic in `get_block_wrapper_attributes()` with attribute-specific merge behavior: - Add explicit merge callbacks for each attribute. - Merge style values safely, normalize trailing semicolons, and sanitize the result. - Merge class values with deduplication . - Treat id and aria-label as override attributes, giving precedence to explicitly passed extra attributes. Props adrock42, mamaduka, r1k0, westonruter, wildworks. Fixes #64603. git-svn-id: https://develop.svn.wordpress.org/trunk@62068 602fd350-edb4-49c9-b593-d223f7449a82
Seemingly as a side effect of [61438], the built code base contains a number of files and directories that have been moved or removed. `grunt clean` was updated to be aware of the newly expected files in [62051], but the `clean` tasks required to ensure a pristine working state are not run prior to `build`. This runs the `clean --dev` task is run immediately before `grunt build` runs as an attempt to clean up these files by ensuring a clean `src` directory. Props jorbin. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62069 602fd350-edb4-49c9-b593-d223f7449a82
… encountering an invalid one Change `return` to `continue` in `data_wp_bind_processor` so that when an element has multiple `data-wp-bind` directives and one is invalid (empty suffix or unique ID), the invalid entry is skipped instead of causing the entire function to exit, allowing valid directives on the same element to still be processed. Props DAreRodz, ozgursar, alexodiy. Fixes #64518. git-svn-id: https://develop.svn.wordpress.org/trunk@62070 602fd350-edb4-49c9-b593-d223f7449a82
This removes some configuration settings and the `copyDirectory()` function. These files are copied by `grunt copy` as of [61873]. Props peterwilsoncc. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62071 602fd350-edb4-49c9-b593-d223f7449a82
The generated `wp-includes/assets/script-loader-packages.min.php` and `wp-includes/assets/script-modules-packages.min.php` files are not actually minified. Additionally, the only purpose they serve is to pass a different script handle to the script loader (`.min.js` vs. `.js`). This eliminates the need for those files entirely since the difference in file size is negligible, and a human-readable version is more useful. Props peterwilsoncc, desrosj. Fixes #64909. git-svn-id: https://develop.svn.wordpress.org/trunk@62072 602fd350-edb4-49c9-b593-d223f7449a82
The `index.min.asset.php` file for each script bundled through the built asset from the `gutenberg` repository contains the `dependencies` and `version` hash for each script. These values are merged into the `script-loader-packages.php` file during a `build`, so the original PHP files are not required. Props peterwilsoncc, desrosj. Fixes #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62073 602fd350-edb4-49c9-b593-d223f7449a82
…specific lock text when RTC is enabled. When RTC is enabled, the post list should not show an exclusive lock icon or user-specific lock text since multiple users can collaboratively edit the same post. Merges a fix from Gutenberg: WordPress/gutenberg#76322. Developed in: WordPress#11234. See #64622. Props maxschmeling, czarate, mcsf, shekharnwagh. git-svn-id: https://develop.svn.wordpress.org/trunk@62074 602fd350-edb4-49c9-b593-d223f7449a82
This provides an easy way at config level to disable real-time collaboration. Developed in: WordPress#11311. See #64904. Props alecgeatches, ingeniumed, zieladam, peterwilsoncc, tyxla. git-svn-id: https://develop.svn.wordpress.org/trunk@62075 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `487a096a9782ba6110a7686d7b4b2d0c55ed1b06` to `2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d`. The following changes are included: - RTC: Backport race condition fix (WordPress/gutenberg#76649) - Fix navigation block rendering unit test (WordPress/gutenberg#76685) - Hide Additional CSS controls when block is inside contentOnly editing mode (WordPress/gutenberg#76512) - RTC: Increase polling intervals, increase polling on primary room only (WordPress/gutenberg#76704) - Navigation: Avoid List View changing position when navigation block saves (WordPress/gutenberg#76659) - Fix navigation block unit test and e2e test (WordPress/gutenberg#76692) - Fix locked content when switching to a different template without exiting 'Edit pattern' (WordPress/gutenberg#76710) - Metabox: Fix checkbox style in sidebar (WordPress/gutenberg#76718) - Stop keeping stale controlled blocks after reset (WordPress/gutenberg#76591) - Gate client-side media processing as plugin-only (WordPress/gutenberg#76700) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/487a096a9782ba6110a7686d7b4b2d0c55ed1b06…2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d. Log created with: git log --reverse --format="- %s" 487a096a9782ba6110a7686d7b4b2d0c55ed1b06..2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62076 602fd350-edb4-49c9-b593-d223f7449a82
This makes several changes to the build script to place the icon library files into more appropriate locations. - The icon library SVG files are now copied into the `wp-includes/images/icon-library` directory instead of `wp-includes/icons`. - The name of the `manifest.php` file has changed to `icon-library-manifest.php` and is now copied to `wp-includes/assets`. - An unnecessary `trailingslashit()` has been removed. - The `gutenberg-` prefix for the corresponding `grunt copy` tasks has been removed. These values are merged into the `script-loader-packages.php` file during a `build`, so the original PHP files are not required. Props mcsf, desrosj. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62077 602fd350-edb4-49c9-b593-d223f7449a82
…riting options. The `WP_ALLOW_COLLABORATION` constant was introduced in [62075] to support disabling RTC at the host level or at the wp-config.php level. A part of that commit is about hiding the "Enable RTC" checkbox in the writing options when RTC is explicitly disallowed via the constant. This commit fixes an error in the condition to hide that checkbox. Props zieladam, tyxla. See #64904. git-svn-id: https://develop.svn.wordpress.org/trunk@62078 602fd350-edb4-49c9-b593-d223f7449a82
The `registry.php` file within the built assets from the `gutenberg` repository contains an accurate list of active, stable routes. However, the `build/routes/` directory has the JavaScript and PHP files for all routes, regardless of their status. This makes adjustments to the `grunt copy` tasks responsible for copying these files into the appropriate locations to extract the list of routes specified in the `registry.php` file so that only the required files are copied. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62079 602fd350-edb4-49c9-b593-d223f7449a82
Should any scripts contain calls to `import()`, the browser won't be able to resolve bare import specifiers unless the import map is already in the DOM. Thus, rather than rely on hook registration order, which is fallible, ensure that the newer callback `WP_Script_Modules::print_import_map` (since 6.5.0) has a lower priority than `_wp_footer_scripts`. Reviewed by jonsurrell. Props mlaetitia. Fixes #64907. git-svn-id: https://develop.svn.wordpress.org/trunk@62080 602fd350-edb4-49c9-b593-d223f7449a82
Punt the wasm-vips client-side media processing feature to a future release when it can include more features. The VIPS WASM worker adds too much build size overhead for the current value provided. Removes all PHP functions, REST API endpoints, cross-origin isolation infrastructure, VIPS script module handling, build configuration, and associated tests. Props adamsilverstein, jorbin. Fixes #64906. git-svn-id: https://develop.svn.wordpress.org/trunk@62081 602fd350-edb4-49c9-b593-d223f7449a82
The client-side media processing removal emptied these files instead of deleting them, causing PHPCS coding standards failures. Follow-up to [62081]. Props adamsilverstein. See #64906. git-svn-id: https://develop.svn.wordpress.org/trunk@62082 602fd350-edb4-49c9-b593-d223f7449a82
Only the most recent innovation release should be tested. Follow up to [61875]. See #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62083 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@62084 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@62085 602fd350-edb4-49c9-b593-d223f7449a82
This removes a redundant conditional in the `check_import_new_users()` function, simplifying its logic to directly return the result of the permission check. Follow-up to [https://mu.trac.wordpress.org/changeset/1829 mu:1829], [39945]. Props Soean. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@62086 602fd350-edb4-49c9-b593-d223f7449a82
The latest version includes various bug fixes, as well as improvements for PHP 8.5 support. References: * [https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.25 getID3 1.9.25 release notes] * [JamesHeinrich/getID3@v1.9.24...v1.9.25 Full list of changes in getID3 1.9.25] Follow-up to [47601], [48278], [52254], [54376], [56975], [61253]. Props Presskopp, SergeyBiryukov. Fixes #64914. git-svn-id: https://develop.svn.wordpress.org/trunk@62087 602fd350-edb4-49c9-b593-d223f7449a82
…hp`. Props ravikhadka. Fixes #64920. git-svn-id: https://develop.svn.wordpress.org/trunk@62088 602fd350-edb4-49c9-b593-d223f7449a82
Fix issue where the selected state dot on radio buttons was not centered when scaling is set to a value greater than 100%. Remove the `.tog` class and styles, unused since [26072]. Props presskopp, siliconforks, suhan2411, sabernhardt, shailu25, joedolson. Fixes #64816. git-svn-id: https://develop.svn.wordpress.org/trunk@62089 602fd350-edb4-49c9-b593-d223f7449a82
Following [61598], the upload button for plugins and themes could cover the file information in the file input for longer internationalized strings due to absolute positioning. Update layout to use remove absolute positioning while retaining the larger drop area. Props audrasjb, pratiknawkar94, huzaifaalmesbah, noruzzaman, presskopp, joedolson. Fixes #64832. git-svn-id: https://develop.svn.wordpress.org/trunk@62090 602fd350-edb4-49c9-b593-d223f7449a82
…s()`. There is no need to initialize `$post_counts` as an empty array, since it will be overwritten directly by the filter value in the next line. Follow-up to [54262]. Props Soean. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@62091 602fd350-edb4-49c9-b593-d223f7449a82
…functionality_constants() The constant was defined in wp_functionality_constants(), which runs in wp-settings.php after collaboration.php is loaded. That created a boot-order edge case where wp_is_collaboration_enabled() could be called before the constant existed – for instance via SHORTINIT. Move the constant definition into a new wp_is_collaboration_allowed() function in collaboration.php. The function checks the constant, and if it's missing, defines it on the spot from the environment variable (defaulting to true). wp_is_collaboration_enabled() now delegates to wp_is_collaboration_allowed() for the constant check, and the admin UI calls wp_is_collaboration_allowed() directly to decide whether to show the checkbox or a "disabled" notice.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Moves the
WP_ALLOW_COLLABORATIONconstant definition out ofwp_functionality_constants()indefault-constants.phpand into a newwp_is_collaboration_allowed()function incollaboration.php. The constant is now defined on first access rather than at a fixed point in the boot sequence.Rationale
wp_functionality_constants()runs inwp-settings.phpaftercollaboration.phpis loaded. If anything callswp_is_collaboration_enabled()before that point — for example during aSHORTINITboot — the constant doesn't exist yet.The same gotcha applies to
AUTOSAVE_INTERVAL,EMPTY_TRASH_DAYS, and other constants in that function, but collaboration is new code, so we can avoid the pattern from the start.Implementation
Added
wp_is_collaboration_allowed()which:WP_ALLOW_COLLABORATIONis already defined (e.g. inwp-config.php)WP_ALLOW_COLLABORATIONenvironment variabletrueif no env var is set, or'true' === $env_valueif it iswp_is_collaboration_enabled()now delegates towp_is_collaboration_allowed()instead of checking the constant directly. The admin UI inoptions-writing.phpcallswp_is_collaboration_allowed()to decide whether to render the checkbox or the "disabled" notice.Testing instructions
WP_ALLOW_COLLABORATIONis not defined or istruedefine( 'WP_ALLOW_COLLABORATION', false );towp-config.php— the checkbox should be replaced by a "disabled" noticeWP_ALLOW_COLLABORATION=falseas an environment variable — same "disabled" notice should appear