docs(framework): Move version selector into scrollable sidebar #6454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
requested review from
danieljanes,
panh99 and
tanertopal
as code owners
github-actions
bot
added
the
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The version dropdown in the docs sidebar couldn't scroll when expanded. With 24+ versions, users on smaller screens couldn't access other versions at all. See this page:
Related issues/PRs
Fixes #6329
Proposal
Explanation
The simplest fix would be adding
overflow-y: autoandmax-heightto the existing dropdown CSS. But since we're touching this anyway, this PR takes the opportunity to improve the UI: moved the version selector inside the sidebar's scrollable area so everything scrolls together, and rewrote it to use Furo's native collapsible pattern. Now appears as a "Versions" item under a "More" section, matching the rest of the sidebar styling. But I'm open to feedback if the simpler CSS-only fix is preferred.It looks like:
Checklist
#contributions)Any other comments?