Skip to content

New: allow prehook invocation to be optional (fixes #21) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

New: allow prehook invocation to be optional (fixes #21) #22

merged 2 commits into from
Feb 18, 2025

Conversation

chris-steele
Copy link
Contributor

#21

New

  • Allow prehook invocation to be optional

@chris-steele chris-steele mentioned this pull request Feb 17, 2025
Merged
taylortom
taylortom requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the code so both pre & post match.
Happy to go with !== false approach for both.

taylortom
taylortom approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta

@taylortom taylortom merged commit cff101c into master Feb 18, 2025
1 check passed
@taylortom taylortom deleted the issue/21 branch February 18, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylortom taylortom taylortom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
adapt-authoring: The TODO Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-steele @taylortom