Skip to content

Comments

Fix: assetManagementCollectionView this.pageSize calculations fixed (fixes #330)#331

Merged
taylortom merged 1 commit intomasterfrom
issue/330
Jun 19, 2025
Merged

Fix: assetManagementCollectionView this.pageSize calculations fixed (fixes #330)#331
taylortom merged 1 commit intomasterfrom
issue/330

Conversation

@joe-allen-89
Copy link
Contributor

#330

Fix

@joe-allen-89 joe-allen-89 requested a review from taylortom June 18, 2025 02:12
@joe-allen-89 joe-allen-89 self-assigned this Jun 18, 2025
@joe-allen-89 joe-allen-89 added the bug An error has occurred label Jun 18, 2025
@joe-allen-89 joe-allen-89 moved this from New to Needs Reviewing in adapt-authoring: The TODO Board Jun 18, 2025
@taylortom taylortom merged commit 95f0562 into master Jun 19, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Merged in adapt-authoring: The TODO Board Jun 19, 2025
@taylortom taylortom deleted the issue/330 branch June 19, 2025 16:39
github-actions bot pushed a commit that referenced this pull request Sep 1, 2025
# 1.0.0 (2025-09-01)

### Fix

* add check for _backboneForms when checking empty fieldsets (fixes #328) (#329) ([c87d5e9](c87d5e9)), closes [#328](#328) [#329](#329)
* apiCollection fetch call removed on pageEditor render ([5efaa28](5efaa28))
* apiCollection fetch call removed on pageEditor render (fixes #277) (#278) ([3a480ff](3a480ff)), closes [#277](#277) [#278](#278)
* assetManagementCollectionView this.pageSize calculations fixed ([b0bb625](b0bb625))
* assetManagementCollectionView this.pageSize calculations fixed ([99df917](99df917))
* assetManagementCollectionView this.pageSize calculations fixed (fixes #330) (#331) ([95f0562](95f0562)), closes [#330](#330) [#331](#331)
* check type before displaying app.componentcopyerror ([d4c0c42](d4c0c42))
* check type before displaying app.componentcopyerror (fixes #255) (#256) ([92b77d6](92b77d6)), closes [#255](#255) [#256](#256)
* CKEditor stripping out needed HTML attributes (#216) (#267) ([c76cfb0](c76cfb0)), closes [#216](#216) [#267](#267)
* correct scope to resolve (fixes #286) (#287) ([b785d4d](b785d4d)), closes [#286](#286) [#287](#287)
* duplicate search results (fixes #103) (#251) ([3ac5147](3ac5147)), closes [#103](#103) [#251](#251)
* Error on course creation (fixes #257) (#258) ([b3e7e0c](b3e7e0c)), closes [#257](#257) [#258](#258)
* extraAllowedContent added for ckeditor ([b2bcfee](b2bcfee))
* fetch regular expression only selecting rel='next' ([3c664fc](3c664fc))
* fetch regular expression should only select rel='next' (fixes #275) (#276) ([e9c9f79](e9c9f79)), closes [#275](#275) [#276](#276)
* fix functionality to add and remove all tags from assets ([342a8b5](342a8b5))
* fix functionality to add and remove all tags from assets (fixes #241 & #142) (#242) ([f38dbe1](f38dbe1)), closes [#241](#241) [#142](#142) [#242](#242)
* Fixed broken svg thumbnail images (fixes #224) (#238) ([41c9d01](41c9d01)), closes [#224](#224) [#238](#238)
* listen to destroy event to update preset dropdown. ([dea5895](dea5895))
* listen to destroy event to update preset dropdown. ([9ae7a12](9ae7a12))
* listen to destroy event to update preset dropdown. (#214) ([a51a35a](a51a35a)), closes [#214](#214)
* Menu picker button mislabeled. ([d5d1c05](d5d1c05))
* Menu picker button mislabeled. (#211) ([f2abaf1](f2abaf1)), closes [#211](#211)
* Modal style amended to prevent overhang (fixes: 139) (#303) ([b4b4421](b4b4421)), closes [#303](#303)
* New asset creation when no tags set (fixes #259) (#260) ([425b2fa](425b2fa)), closes [#259](#259) [#260](#260)
* Optional chaining added to data on snackbar close ([1d8267c](1d8267c))
* Optional chaining added to data on snackbar close (fixes #281) (#282) ([1c89113](1c89113)), closes [#281](#281) [#282](#282)
* page drag and drop behaviour (fixes #239) (#240) ([99879e8](99879e8)), closes [#239](#239) [#240](#240)
* polyglot.min.js updated to v2.4.2 ([311fcca](311fcca))
* postRender fix tags create function (fixes #227) ([0560312](0560312)), closes [#227](#227)
* Prevent enter key default behaviour on form fields. ([8f1a355](8f1a355))
* Prevent enter key default behaviour on form fields. (#70) (#218) ([6f89f50](6f89f50)), closes [#70](#70) [#218](#218)
* prevent Origin.editor.data.content from being overwritten until fetch completed (fixes #274) (#304) ([7c31f36](7c31f36)), closes [#274](#274) [#304](#304)
* prevent projects being duplicated in dashboard (fixes #293) (#294) ([8ab4dff](8ab4dff)), closes [#293](#293) [#294](#294)
* projectsView this.pageSize calculations fixed (fixes #332) (#333) ([1659c57](1659c57)), closes [#332](#332) [#333](#333)
* Reload editor data and refresh view on copy/paste (fixes #192) (#236) ([0c67b1d](0c67b1d)), closes [#192](#192) [#236](#236)
* remove .length from checking collection in renderPluginTypeViews ([8b07cd5](8b07cd5))
* remove .length from checking collection in renderPluginTypeViews (fixes #279) (#280) ([1f0b05f](1f0b05f)), closes [#279](#279) [#280](#280)
* return early for removeItem amended (fixes #305) (#306) ([627049b](627049b)), closes [#305](#305) [#306](#306)
* scope check for new data to selected course (fixes #326) (#327) ([ff33c22](ff33c22)), closes [#326](#326) [#327](#327)
* search by name (fixes #289) (#290) ([ccd885f](ccd885f)), closes [#289](#289) [#290](#290)
* Search project by tags functionality ([e9c900e](e9c900e))
* Search project by tags functionality (fixes #230) (#244) ([02b6965](02b6965)), closes [#230](#230) [#244](#244)
* selected tags UI bug. (fixes #249) (#254) ([1ba8365](1ba8365)), closes [#249](#249) [#254](#254)
* Tags not deleting when typing and new tags created (#168 #227 #229) (#225) ([c28f138](c28f138)), closes [#168](#168) [#227](#227) [#229](#229) [#225](#225)
* themes being pulled through on showPresetEdit. ([2ab0c09](2ab0c09))
* themes being pulled through on showPresetEdit. (#212) ([3385a82](3385a82)), closes [#212](#212)
* Typing a new tag will no longer remove existing. ([c0943a2](c0943a2))
* typo in contentModel pruneAttributes function ([f11b3a7](f11b3a7))
* update editorPageView render to try/catch consistent with editorDataLoader ([d109a85](d109a85))
* update editorPageView render to try/catch consistent with editorDataLoader (fixes #271) (#272) ([4d71012](4d71012)), closes [#271](#271) [#272](#272)
* use getValue to check selected items, force focus to avoid cursor vanishing. ([ed04e3f](ed04e3f))
* Whitespace changes removed. ([4574360](4574360))

### New

* automated release functionality added to the repo ([cf25ee6](cf25ee6))
* automated release functionality added to the repo (fixes #334) (#335) ([5233154](5233154)), closes [#334](#334) [#335](#335)

### Update

* added loading popup when copying page/menu (fixes #308) (#309) ([887b27f](887b27f)), closes [#308](#308) [#309](#309)
* Selectize library updated (fixes #229) ([514d3ee](514d3ee)), closes [#229](#229)
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An error has occurred released

Projects

Development

Successfully merging this pull request may close these issues.

Issue with assetManagementCollectionView when calculating this.pageSize

2 participants