Update: Replace dialog button aria-expanded with aria-haspopup dialog (fixes #657) #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
approved these changes
May 12, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
Member
|
🎉 This PR is included in version 6.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
For navigation buttons that trigger a dialog to open (Notify popup or Drawer), the button
aria-expandedhas been replaced witharia-haspopup="dialog". Please refer to the issue for the research and discussion supporting this change.Fixes Improper use of aria-expanded for nav buttons which trigger drawer / notify dialog #657
Remove
aria-expandedfrom Drawer<dialog>as this serves no purpose and it is not the intended use. See MDN note for reference below or refer to the issue description.Fixes Improper use of aria-expanded for drawer dialog #658
Testing
Navigate to the Resources button in the nav bar using a screen reader. Depending on the browser/screen reader used, expect the following reading....
VoiceOver “Open course resources, dialog pop-up, button”
NVDA “Open course resources, button opens dialog”
JAWS “Open course resources, button has popup dialog”
Tested with the following combinations:
VoiceOver Safari macOS and iPhone
VoiceOver Chrome and Firefox macOS
JAWS Chrome, Edge and Firefox Windows
NVDA Chrome, Edge and Firefox Windows
Related PRs
Other navigation plugins that include
aria-expandedfor buttons that open Drawer or Notify popup dialogs will also need updating. Please see summary below.Resources and Glossary have been addressed with this PR.
PLP PR - Update: Replace dialog button aria-expanded with aria-haspopup dialog (fixes #250) adapt-contrib-pageLevelProgress#251
Visua11y PR- Update: Replace dialog button aria-expanded with aria-haspopup dialog (fixes #129) cgkineo/adapt-visua11y#130