Fix: Check _canShowCorrectness value before applying item-level classes (#240) #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahirodoherty-learningpool
moved this from New
to Needs Reviewing
in adapt_framework: The TODO Board
Copilot started reviewing on behalf of
cahirodoherty-learningpool
December 22, 2025 16:20
View session
ethan-lp
approved these changes
Dec 22, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #240 by ensuring that item-level correctness classes (is-correct and is-incorrect) are only applied when the _canShowCorrectness configuration is enabled. Additionally, it corrects a typo in the pull request template.
- Added
_canShowCorrectnesscheck to item-level class conditions for consistent behavior with component-level correctness display - Fixed typo in pull request template ("udpate" → "update")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/mcq.jsx | Added _canShowCorrectness check before applying is-correct and is-incorrect classes to individual MCQ items, ensuring consistency with the component-level correctness display configuration |
| .github/pull_request_template.md | Fixed spelling error in the "Update" section header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Fix