Skip to content

Fix: Make contentObject:_pageLevelProgress._isEnabled atomic on nested submenus (fixes #247) #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-replin merged 2 commits into from
Apr 22, 2025
Merged

Fix: Make contentObject:_pageLevelProgress._isEnabled atomic on nested submenus (fixes #247) #249

joe-replin merged 2 commits into from
Apr 22, 2025

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Mar 25, 2025 •
edited
Loading

fixes #247

alternative to #248

Fix

  • All descendant pages will be shown, when configured with _pageLevelProgress: true, they will be shown nested if their parent has _pageLevelProgress: true or at the current level if their parent is _pageLevelProgress: false

@oliverfoster oliverfoster self-assigned this Mar 25, 2025
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Mar 25, 2025
@oliverfoster oliverfoster mentioned this pull request Mar 25, 2025
Closed
@oliverfoster oliverfoster requested a review from joe-replin March 25, 2025 19:06
@oliverfoster oliverfoster mentioned this pull request Mar 27, 2025
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-replin joe-replin merged commit 21072dd into master Apr 22, 2025
@joe-replin joe-replin deleted the issue/247a branch April 22, 2025 14:23
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 22, 2025
github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
@semantic-release-bot
Chore(release): 8.1.1 [skip ci]
83e7e46 
## [8.1.1](v8.1.0...v8.1.1) (2025-04-22)

### Fix

* Make contentObject:_pageLevelProgress._isEnabled atomic on nested submenus (fixes #247) (#249) ([21072dd](21072dd)), closes [#247](#247) [#249](#249) [#247](#247)
@github-actions
Copy link

github-actions bot commented Apr 22, 2025

🎉 This PR is included in version 8.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe-replin joe-replin joe-replin approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_showAtCourseLevel setting isn't displaying correctly

4 participants

@oliverfoster @joe-replin @cahirodoherty-learningpool