Skip to content

Update: Expose trickle helper for button height (fixes #247) #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joe-replin wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update: Expose trickle helper for button height (fixes #247) #248

joe-replin wants to merge 5 commits into from

Conversation

@joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Dec 19, 2025 •
edited
Loading

Update

  • Export getTrickleButtonHeight via Adapt.trickle
  • Helper measures visible trickle button height (including margins) within a parent container

Testing

Build a course with trickle enabled and verify no regressions in trickle button rendering

@joe-replin joe-replin self-assigned this Dec 19, 2025
@joe-replin joe-replin moved this from New to Needs Reviewing in adapt_framework: The TODO Board Dec 19, 2025
@joe-replin joe-replin linked an issue Dec 19, 2025 that may be closed by this pull request
Expose helper to measure trickle button height #247
Open
@joe-replin joe-replin mentioned this pull request Dec 19, 2025
Open
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-replin joe-replin changed the title Update: expose trickle helper for button height (fixes #247) Update: Expose trickle helper for button height (fixes #247) Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-replin joe-replin

Labels

enhancement

Projects

adapt_framework: The TODO Board
Status: Needs Reviewing

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose helper to measure trickle button height

3 participants

@joe-replin @cahirodoherty-learningpool