Remove Obligatory Question Mark in Paste Dialog Content #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the paste confirmation dialog where a question mark ("?") was being appended to the dialog content regardless of the configured dialogContent value. This behavior was incorrect as:
It might not be grammatically appropriate for all custom dialogContent messages provided by the user.
It introduces a localization challenge as the question mark is hardcoded and not part of the translatable dialogContent. This makes it difficult to provide grammatically correct and natural-sounding prompts in different languages.
To resolve this, the section of the code responsible for adding the trailing question mark has been commented out. This change ensures that the paste confirmation dialog displays the dialogContent exactly as provided by the DialogConfig, giving users full control over the message and improving localization capabilities.