Skip to content

fix(csharp): throw ArgumentException for GetPrimaryKeys with null table name (PECO-2956) #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msrathore-db wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(csharp): throw ArgumentException for GetPrimaryKeys with null table name (PECO-2956) #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions csharp/src/DatabricksStatement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,9 @@ protected override async Task<QueryResult> GetPrimaryKeysAsync(CancellationToken
activity?.SetTag("statement.table_name", TableName ?? "(none)");
activity?.SetTag("statement.feature.pk_fk_enabled", enablePKFK);

if (string.IsNullOrEmpty(TableName))
throw new ArgumentException("Table name is required for GetPrimaryKeys");

if (ShouldReturnEmptyPkFkResult())
{
activity?.AddEvent("statement.get_primary_keys.returning_empty_result", [
Expand Down
6 changes: 4 additions & 2 deletions csharp/src/StatementExecution/StatementExecutionStatement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,11 +1262,13 @@ private async Task<QueryResult> GetPrimaryKeysAsync(CancellationToken cancellati
activity?.SetTag("table", _metadataTableName ?? "(none)");
activity?.SetTag("pk_fk_enabled", _connection.EnablePKFK);

if (string.IsNullOrEmpty(_metadataTableName))
throw new ArgumentException("Table name is required for GetPrimaryKeys");

if (MetadataUtilities.ShouldReturnEmptyPKFKResult(_metadataCatalogName, null, _connection.EnablePKFK))
return MetadataSchemaFactory.CreateEmptyPrimaryKeysResult();

if (string.IsNullOrEmpty(_metadataCatalogName) || string.IsNullOrEmpty(_metadataSchemaName) ||
string.IsNullOrEmpty(_metadataTableName))
if (string.IsNullOrEmpty(_metadataCatalogName) || string.IsNullOrEmpty(_metadataSchemaName))
return MetadataSchemaFactory.CreateEmptyPrimaryKeysResult();

string sql = new ShowKeysCommand(_metadataCatalogName!, _metadataSchemaName!, _metadataTableName!).Build();
Expand Down
Loading