feat(sqlwrapper): add logger to Driver, DBFactory#106
Merged
lidavidm merged 4 commits intoadbc-drivers:mainfrom Dec 15, 2025
Merged
feat(sqlwrapper): add logger to Driver, DBFactory#106lidavidm merged 4 commits intoadbc-drivers:mainfrom
lidavidm merged 4 commits intoadbc-drivers:mainfrom
Conversation
lidavidm
reviewed
Dec 13, 2025
Contributor
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
I vote just adding the logger to the existing interface. In fact, why not just make it a parameter of CreateDB?
Or, we can just have the Database struct implement DBFactory in the drivers, and then it should automatically have access to the logger.
Contributor
|
That said...it seems this interface comes "too late" and maybe we need to make it set the logger on the driver instead. |
… method directly on DriverImplBase
lidavidm
changed the title
lidavidm
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Add DBFactoryWithLogger interface so that DbFactory implmentations can get access to the logger already present on the database object.