Skip to content

feat(csharp): logging enhancements #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davidhcoe wants to merge 7 commits into
base: main
Choose a base branch
from
+245 −172
Draft

feat(csharp): logging enhancements #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c86a88
logging enhancements
Mar 21, 2026
02dd620
Copilot feedback
Mar 21, 2026
5bdc6d1
Apply suggestions from code review
davidhcoe Mar 21, 2026
d2b15e2
Merge remote-tracking branch 'upstream/main' into dev/parallel-and-lo…
birschick-bq Mar 24, 2026
dc6b110
Apply suggestions from code review
birschick-bq Mar 24, 2026
6cbfb0f
Logging improvements
birschick-bq Mar 24, 2026
2b03e66
Small rename
birschick-bq Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<PackageVersion Include="ApacheThrift" Version="0.22.0" />
<PackageVersion Include="System.Text.Json" Version="9.0.9" />
<!-- Testing -->
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.5.61" />
Expand Down
2 changes: 1 addition & 1 deletion csharp/arrow-adbc
Open in desktop
Submodule arrow-adbc updated 264 files
4 changes: 2 additions & 2 deletions csharp/src/Hive2/HiveServer2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,10 +1374,10 @@ internal static void HandleThriftResponse(TStatus status, Activity? activity)
[TStatusCode.ERROR_STATUS] = (status, _) => ThrowErrorResponse(status),
[TStatusCode.INVALID_HANDLE_STATUS] = (status, _) => ThrowErrorResponse(status),
[TStatusCode.STILL_EXECUTING_STATUS] = (status, _) => ThrowErrorResponse(status, AdbcStatusCode.InvalidState),
[TStatusCode.SUCCESS_STATUS] = (status, activity) => activity?.AddTag(SemanticConventions.Db.Response.StatusCode, status.StatusCode),
[TStatusCode.SUCCESS_STATUS] = (status, activity) => activity?.AddTag(SemanticConventions.Db.Response.StatusCode, (int)status.StatusCode),
[TStatusCode.SUCCESS_WITH_INFO_STATUS] = (status, activity) =>
{
activity?.AddTag(SemanticConventions.Db.Response.StatusCode, status.StatusCode);
activity?.AddTag(SemanticConventions.Db.Response.StatusCode, (int)status.StatusCode);
activity?.AddTag(SemanticConventions.Db.Response.InfoMessages, string.Join(Environment.NewLine, status.InfoMessages));
},
};
Expand Down
Loading
Loading