test(go): add tests for unsigned types#91
Merged
Mandukhai-Alimaa merged 3 commits intoadbc-drivers:mainfrom Apr 7, 2026
Merged
test(go): add tests for unsigned types#91Mandukhai-Alimaa merged 3 commits intoadbc-drivers:mainfrom
Mandukhai-Alimaa merged 3 commits intoadbc-drivers:mainfrom
Conversation
lidavidm
approved these changes
Apr 7, 2026
| @@ -0,0 +1 @@ | |||
| SELECT 16384 AS res | |||
Contributor
There was a problem hiding this comment.
(1) is this actually SMALLINT without the cast?
(2) can we use txtcase instead of a bunch of files?
Contributor
Author
There was a problem hiding this comment.
- Yes. MySQL dont support casting to specific integer sizes like SMALLINT or INT. When we use plain integer literals in SELECT queries without CAST, MySQL infers all integer values as int64, regardless of whether the value would fit in a smaller integer type or not.
Contributor
There was a problem hiding this comment.
In that case there's not much point having a literal test for these types if you can't actually get a literal of that type (the select tests are the main important ones, literal isn't required for every type)
Contributor
Author
There was a problem hiding this comment.
Okay, i will hide them.
| @@ -0,0 +1,43 @@ | |||
| // Copyright (c) 2025 ADBC Drivers Contributors | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Add unsigned integer tests and enable int16/int32 literal tests
Closes #82 .