Draft
Conversation
Implement From<ApiError> trait to convert sf_core errors to adbc_core errors, with exhaustive mapping of all 16 ApiError variants to appropriate Status codes. Also add not_implemented() helper for NotImplemented errors.
- Add src/driver.rs: Inner struct (tokio Runtime + DatabaseDriverV1) and Driver wrapping Arc<Inner>, implementing adbc_core::Driver trait - Add stub src/database.rs, src/connection.rs, src/statement.rs that compile with todo!() bodies for later tasks - Update src/lib.rs to expose Driver, Database, Connection, Statement - Fix arrow-array/schema version constraints to match adbc_core (57.x) to avoid duplicate crate instance trait bound failures - Fix error.rs test to use public sf_core APIs instead of pub(crate) snafu builder internals (InvalidArgumentSnafu) - Add .cargo/config.toml with prefer-dynamic=no to work around sf_core dylib linker issues when building test binaries 2 driver tests pass: driver_default_creates_successfully, new_database_succeeds_with_no_options
Replaces the database.rs stub with full Optionable + adbc_core::Database implementation: ADBC key → sf_core param mapping, URI parsing, and new_connection_with_opts that propagates settings and calls connection_init. Adds set_autocommit/execute_simple stubs to connection.rs for compilation. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Implements full connection.rs for Task 5: lifecycle (Drop), set_autocommit/execute_simple helpers, Optionable (AutoCommit, CurrentCatalog, CurrentSchema), and adbc_core::Connection methods (new_statement, get_info, get_table_types, get_table_schema, commit, rollback). Adds snowflake_type_to_arrow mapping for DESC TABLE results. Also adds arrow-buffer v57 as a direct dep to resolve version conflict with arrow-array v57 transitive dep. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Replace the incorrect List<Utf8> arm-5 placeholder in get_info() with a proper empty MapArray (Map<Int32, List<Int32>>) so that RecordBatch::try_new schema validation succeeds. Also fix the UnionFields arm-5 declaration from Field::new_list to Field::new_map to match the adbc_core GET_INFO_SCHEMA.
zeroshade
had a problem deploying
to
Snowflake CI
GitHub Actions
Failure
zeroshade
had a problem deploying
to
Snowflake CI
GitHub Actions
Failure
zeroshade
had a problem deploying
to
Snowflake CI
GitHub Actions
Failure
The windows-latest runner doesn't have OpenSSL pre-installed in the C:\Program Files\OpenSSL-Win64 directory anymore, causing openssl-sys build to fail. Installing it via chocolatey fixes this.
zeroshade
force-pushed
the
feat/rust-adbc-snowflake-driver
branch
from
d7c085e to
baa3e63
Compare
… fix manylinux build
…needed for openssl vendored build
…nside manylinux-rust container
…ation - Correct artifact name in CI from `libadbc_snowflake.*` to `libadbc_driver_snowflake.*`. - Add `rust/license.tpl` (converted to Handlebars for cargo-about). - Add `rust/about.toml` with `[[...clarify.files]]` overrides for un-licensed snowflake local workspace/git dependencies and accept list for various open-source licenses.
The adbc-make check command copies the built .so to rust/build/, not rust/target/release/. The previous path only captured .rlib and .d files, causing empty package generation downstream.
The Rust driver returns 'UNAUTHENTICATED: Failed to login' not 'failed to auth'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rust implementation using
github.com/snowflakedb/universal-driveras the base