This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Added support for Kafka in metrics3 and a sample config - #48
Open
mstump wants to merge 1 commit into
Open
Conversation
mstump
force-pushed
the
v3.0.3-kafka
branch
3 times, most recently
from
July 7, 2017 21:58
a968764 to
fd43c85
Compare
sio2boss
suggested changes
Jul 10, 2017
sio2boss
left a comment
sio2boss
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good other than the version of metrics-kafka
| <dependency> | ||
| <groupId>com.github.mstump</groupId> | ||
| <artifactId>metrics-kafka</artifactId> | ||
| <version>c804bf1874</version> |
Contributor
There was a problem hiding this comment.
Any chance you are planning a 0.0.1 release? mstump/metrics-kafka@47ff721
Author
There was a problem hiding this comment.
yeah, I'll cut a release tonight or tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for issue #47, adding Kafka as a configurable reporter.