Skip to content

Export public helper types from hardtry/types entrypoint#34

Merged
adelrodriguez merged 1 commit intomainfrom
03-07-export_public_helper_types_from_hardtry_types_entrypoint
Mar 7, 2026
Merged

Export public helper types from hardtry/types entrypoint#34
adelrodriguez merged 1 commit intomainfrom
03-07-export_public_helper_types_from_hardtry_types_entrypoint

Conversation

@adelrodriguez
Copy link
Copy Markdown
Owner

No description provided.

@adelrodriguez adelrodriguez marked this pull request as ready for review March 7, 2026 19:11
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 7, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9cbda148-c4af-47d9-a5a6-acb7be911f10

📥 Commits

Reviewing files that changed from the base of the PR and between f834842 and 0d44294.

📒 Files selected for processing (6)
  • README.md
  • bunup.config.ts
  • package.json
  • src/__tests__/types.test.ts
  • src/index.ts
  • src/types.ts

Walkthrough

The change relocates type exports from the main runtime module to a dedicated types module. Types AllSettledResult, SettledFulfilled, SettledRejected, SettledResult, and FlowExit are removed from src/index.ts and re-exported from a new src/types.ts file. The build configuration (bunup.config.ts) is updated to process src/types.ts, and package.json adds a new "./types" export entry pointing to the built type definitions and module. Documentation and tests are updated to reflect the new import path for these types.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 03-07-export_public_helper_types_from_hardtry_types_entrypoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

adelrodriguez commented Mar 7, 2026

@adelrodriguez adelrodriguez changed the base branch from 03-07-extract_shared_task-graph_coordination_base_class_from_flowexecution___taskexecution_ to graphite-base/34 March 7, 2026 19:16
@adelrodriguez adelrodriguez force-pushed the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch from 986bd60 to 15c2902 Compare March 7, 2026 19:16
@adelrodriguez adelrodriguez changed the base branch from graphite-base/34 to 03-07-extract_shared_task-graph_coordination_base_class_from_flowexecution___taskexecution_ March 7, 2026 19:16
@adelrodriguez adelrodriguez force-pushed the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch from 15c2902 to c527ef1 Compare March 7, 2026 19:22
@adelrodriguez adelrodriguez force-pushed the 03-07-extract_shared_task-graph_coordination_base_class_from_flowexecution___taskexecution_ branch from f945f82 to a90f927 Compare March 7, 2026 19:22
@adelrodriguez adelrodriguez force-pushed the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch from c527ef1 to c5faeb1 Compare March 7, 2026 19:32
@adelrodriguez adelrodriguez force-pushed the 03-07-extract_shared_task-graph_coordination_base_class_from_flowexecution___taskexecution_ branch from a90f927 to 088550a Compare March 7, 2026 19:32
@adelrodriguez adelrodriguez force-pushed the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch from c5faeb1 to c4bc3cf Compare March 7, 2026 19:34
Copy link
Copy Markdown
Owner Author

adelrodriguez commented Mar 7, 2026

Merge activity

  • Mar 7, 7:35 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 7, 7:36 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 7, 7:37 PM UTC: @adelrodriguez merged this pull request with Graphite.

@adelrodriguez adelrodriguez changed the base branch from 03-07-extract_shared_task-graph_coordination_base_class_from_flowexecution___taskexecution_ to graphite-base/34 March 7, 2026 19:35
@adelrodriguez adelrodriguez changed the base branch from graphite-base/34 to main March 7, 2026 19:35
@adelrodriguez adelrodriguez force-pushed the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch from c4bc3cf to 0d44294 Compare March 7, 2026 19:36
@adelrodriguez adelrodriguez merged commit c7bfbae into main Mar 7, 2026
6 of 7 checks passed
@adelrodriguez adelrodriguez deleted the 03-07-export_public_helper_types_from_hardtry_types_entrypoint branch March 7, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant