Optimize signal handling to avoid unnecessary controller creation

[adelrodriguez]

No description provided.

[adelrodriguez]

• Optimize signal handling to avoid unnecessary controller creation #37 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a6abc8e-3808-42bd-9bac-91134fe21016

📥 Commits

Reviewing files that changed from the base of the PR and between abaa689 and 2e757dc.

📒 Files selected for processing (8)

• .plans/03-disposable-polyfill-plan.md
• .plans/04-baseexecution-lazy-control-plan.md
• src/__tests__/run.test.ts
• src/lib/__tests__/coverage-exceptions.test.ts
• src/lib/executors/all-settled.ts
• src/lib/executors/all.ts
• src/lib/executors/base.ts
• src/lib/executors/flow.ts

💤 Files with no reviewable changes (2)

• .plans/04-baseexecution-lazy-control-plan.md
• .plans/03-disposable-polyfill-plan.md

---

Walkthrough

This PR removes two planning documents and implements a refactor of BaseExecution to support lazy instantiation of timeout and signal controllers. The changes introduce an executionSignal abstraction that composes these controllers, along with new protected helper methods for cancellation checking and promise racing. Multiple executor implementations are updated to use the new signal and cancellation paths instead of directly accessing controller instances.

Possibly related PRs

• Add context documentation for BaseExecution optimization and DisposableStack polyfill #21: Directly implements the BaseExecution lazy-control refactor that introduces executionSignal, factory methods for lazy controller creation, and updated executor call-sites.
• Implement Phase 11 flow with $exit functionality #15: Updates FlowExecution to use the new executionSignal and raceWithCancellation paths for execution signal handling.
• Implement Phase 4 timeout functionality with full builder chain support #5: Integrates TimeoutController into the execution flow with timeout-aware racing and timeout error handling logic.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author; the PR relies solely on the title for context.	Add a description explaining the optimization approach, performance benefits, and rationale for the lazy controller creation strategy.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main optimization goal: avoiding unnecessary controller creation in signal handling, which aligns with the core changes refactoring signal/timeout controller instantiation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 03-07-optimize_signal_handling_to_avoid_unnecessary_controller_creation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[adelrodriguez]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".