fix(memory): patch ConcurrentStorage leak (WeakValueDictionary)#1353
Merged
TimothyZhang7 merged 2 commits intoaden-hive:mainfrom Jan 27, 2026
Merged
Conversation
jhalak999
pushed a commit
to jhalak999/hive
that referenced
this pull request
Feb 17, 2026
…rage-file-locks-leak fix(memory): patch ConcurrentStorage leak (WeakValueDictionary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #517 (Memory leak in concurrent storage)
This PR addresses the unbounded memory growth in
ConcurrentStorageby replacing the global lock cache with aWeakValueDictionaryand implementing strict LRU eviction for active run locks.Changes
_global_locklogic withWeakValueDictionaryto allow unused file locks to be garbage collected._lru_tracking(OrderedDict) to keep 'hot' run locks in memory while evicting cold ones.max_locksparameter to control memory usage.Verification
tests/test_concurrent_storage_leak.pyverifying: