Skip to content

Test/storage module coverage#1509

Merged
bryanadenhq merged 6 commits intoaden-hive:mainfrom
brilliantkid87:test/storage-module-coverage
Jan 28, 2026
Merged

Test/storage module coverage#1509
bryanadenhq merged 6 commits intoaden-hive:mainfrom
brilliantkid87:test/storage-module-coverage

Conversation

@brilliantkid87
Copy link
Contributor

@brilliantkid87 brilliantkid87 commented Jan 27, 2026

Description

Add comprehensive test coverage for the framework/storage/ module (backend.py, concurrent.py), which currently has no dedicated tests despite handling critical functionality for persisting runs and agent state.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Related Issues

Fixes #902

Changes Made

  • Add core/tests/test_storage.py with 32 test cases covering:
    • FileStorage basics: directory creation, path handling
    • FileStorage CRUD: save, load, delete runs and summaries
    • FileStorage indexing: by goal, status, and node
    • FileStorage list operations: list all runs/goals, stats
    • CacheEntry expiration logic
    • ConcurrentStorage lifecycle: start/stop
    • ConcurrentStorage async CRUD with caching
    • ConcurrentStorage sync API for backward compatibility
    • ConcurrentStorage cache management and statistics

Testing

  • Unit tests pass (cd core && pytest tests/test_storage.py -v)
  • Lint passes (cd core && ruff check .)
  • Manual testing performed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A - Test-only changes

Copy link
Collaborator

@bryanadenhq bryanadenhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good.

Copy link
Collaborator

@bryanadenhq bryanadenhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, thanks for contributing!

@bryanadenhq
Copy link
Collaborator

Hi @brilliantkid87, could you please fix the linter error? Once this is fixed, it looks good to merge. Thanks!

@brilliantkid87
Copy link
Contributor Author

hi @bryanadenhq, I will be fix the linter error

@brilliantkid87
Copy link
Contributor Author

hi @bryanadenhq, i already fix the linter error

@bryanadenhq
Copy link
Collaborator

Hi @brilliantkid87, it seems like there is still one more left. Sorry about the inconvenience!

@brilliantkid87
Copy link
Contributor Author

hi @bryanadenhq, I will check

@brilliantkid87
Copy link
Contributor Author

hi @bryanadenhq , i already fix. please check it

@bryanadenhq bryanadenhq merged commit 031b205 into aden-hive:main Jan 28, 2026
4 checks passed
@bryanadenhq
Copy link
Collaborator

Hi @brilliantkid87, thanks so much for your contribution!

@brilliantkid87
Copy link
Contributor Author

Anytime! Happy to help @bryanadenhq

jhalak999 pushed a commit to jhalak999/hive that referenced this pull request Feb 17, 2026
…dule-coverage

Test/storage module coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(core): Add test coverage for storage module (backend.py, concurrent.py)

2 participants