Fix: Windows Security Vulnerability and Test Failures (#1430)#1617
Closed
Tahir-yamin wants to merge 8 commits intoaden-hive:mainfrom
Closed
Fix: Windows Security Vulnerability and Test Failures (#1430)#1617Tahir-yamin wants to merge 8 commits intoaden-hive:mainfrom
Tahir-yamin wants to merge 8 commits intoaden-hive:mainfrom
Conversation
added 2 commits
January 27, 2026 22:56
- Security: Fixed path traversal vulnerability on Windows in security.py - Tests: Fixed credential tests to match optional Anthropic key design - Tests: Mocked subprocess.run in file system tests for cross-platform compatibility - Tests: Added mocked happy path for web search tool
Contributor
Author
|
@TimothyZhang7 @mishrapravin114 This is the fresh PR for #1430 (and #1609) since #1424 was closed. Could you please assign this PR to @Tahir-yamin as well? Thanks! |
added 6 commits
January 28, 2026 10:40
Collaborator
|
Closing this PR. The scope is too broad (30 files, 2300+ lines) and includes files that shouldn't be committed (.coverage, test_out.txt, pr_diff.patch). Issue #1430 remains open for a more focused contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the security vulnerability on Windows during runtime initialization and fixes the associated test failures in
stream_runtime.py.Changes
DecisionTypeenum (linked to Bug: Invalid DecisionType Enum Member (AttributeError on TOOL_CALL) #1609).core/framework/runtime/stream_runtime.pyfrom 38% to 77%.Fixes #1430