fix: handleKeyError in slack _get_user_token for unregistered credential#6042
Open
Amdev-5 wants to merge 1 commit intoaden-hive:mainfrom
Open
fix: handleKeyError in slack _get_user_token for unregistered credential#6042Amdev-5 wants to merge 1 commit intoaden-hive:mainfrom
Amdev-5 wants to merge 1 commit intoaden-hive:mainfrom
Conversation
…tial
`credentials.get("slack_user")` raises KeyError because "slack_user"
is not defined in CREDENTIAL_SPECS (only "slack" is registered).
Added try/except to gracefully fall back to SLACK_USER_TOKEN env var.
Fixes aden-hive#6041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6041
Summary
_get_user_token()inslack_tool.pycallscredentials.get("slack_user"), but"slack_user"is not registered inCREDENTIAL_SPECS(only"slack"is)CredentialStoreAdapter.get()raisesKeyErrorfor unregistered credential names, crashing any code path that calls_get_user_token()(e.g.slack_search)try/except KeyErrorto gracefully fall back toSLACK_USER_TOKENenv var, matching the existing fallback patternRoot Cause
CREDENTIAL_SPECSinslack.pyonly defines"slack"(bot token). The"slack_user"name was never registered, socredentials.get("slack_user")hits the unknown-name guard instore_adapter.py(line 108-109) and raisesKeyError.Confirmed this pattern is unique to the Slack tool — all other tools only call
credentials.get()with registeredcredential names.
Fixes #6041