fix(server): use session.phase_state instead of session.mode_state in…#6069
Open
xpushkal wants to merge 1 commit intoaden-hive:mainfrom
Open
fix(server): use session.phase_state instead of session.mode_state in…#6069xpushkal wants to merge 1 commit intoaden-hive:mainfrom
xpushkal wants to merge 1 commit intoaden-hive:mainfrom
Conversation
… handle_pause The handle_pause endpoint referenced session.mode_state (lines 360-361), which does not exist on the Session dataclass. This caused an AttributeError every time the pause endpoint reached the phase transition step, preventing the queen phase from transitioning to staging and returning a 500 error to the frontend. Changed to session.phase_state, consistent with handle_stop (line 412), handle_run (line 75), and the Session dataclass definition (session_manager.py line 44).
PR Requirements WarningThis PR does not meet the contribution requirements. Missing: No linked issue found. To fix:
Exception: To bypass this requirement, you can:
Micro-fix requirements (must meet ALL):
Why is this required? See #472 for details. |
There was a problem hiding this comment.
Pull request overview
Fixes the /pause execution route to use the correct Session attribute (phase_state) when switching the queen from running → staging, preventing an AttributeError and resulting 500s during pause-triggered phase transitions.
Changes:
- Replace the invalid
session.mode_statereference withsession.phase_stateinhandle_pause. - Align pause-phase transition logic with
handle_trigger/handle_stopand theSessiondataclass.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #5991
… handle_pause
The handle_pause endpoint referenced session.mode_state (lines 360-361), which does not exist on the Session dataclass. This caused an AttributeError every time the pause endpoint reached the phase transition step, preventing the queen phase from transitioning to staging and returning a 500 error to the frontend.
Changed to session.phase_state, consistent with handle_stop (line 412), handle_run (line 75), and the Session dataclass definition (session_manager.py line 44).
Description
Brief description of the changes in this PR.
Type of Change
Related Issues
Fixes #(issue number)
Changes Made
Testing
Describe the tests you ran to verify your changes:
cd core && pytest tests/)cd core && ruff check .)Checklist
Screenshots (if applicable)
Add screenshots to demonstrate UI changes.