Merged
Conversation
Comprehensive removal spec for the unused playbackMode feature. Gate mode was made obsolete by Phase 29B tied notes implementation. Includes migration strategy, test verification, and ~77 files to update.
Audit revealed 3 missing files: - app/src/App.tsx (default track creation) - app/src/worker/logging.ts (hash interfaces) - app/scripts/debug-ws-storm-local.ts (test fixtures) Also added note about 'gated' vs 'gate' inconsistency in session-api.ts. Updated file count estimate from ~77 to ~80 files.
adewale
added a commit
that referenced
this pull request
Jan 1, 2026
Phase 29B per-step ties made playbackMode obsolete. This commit completes the removal started in PR #26: - Remove PlaybackMode type from sync-types.ts and types.ts - Update playSample() signature: 7→6 params (remove playbackMode) - Remove UI buttons and handlers from TrackRow - Remove multiplayer message handlers and sync logic - Remove reducer case from grid.tsx - Update all test fixtures (~28 test files) - Remove playbackMode from session JSON files (18 files) - Delete gate-mode-demo.json - Keep optional playbackMode?: string in SessionTrack for backwards compat 76 files changed, 687 lines removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.