fix(circulation): filter organisation by slug and not by name #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velrest
force-pushed
the
fix_organisation_member_filter
branch
2 times, most recently
from
0f6ce0b to
e71509e
Compare
velrest
force-pushed
the
fix_organisation_member_filter
branch
from
e71509e to
70ce330
Compare
open-dynaMIX
approved these changes
Jan 15, 2026
Member
open-dynaMIX
left a comment
open-dynaMIX
left a comment
There was a problem hiding this comment.
BE changes look good 👍 And the wiki is also already updated 🚀 🎉
StephanH90
approved these changes
Jan 15, 2026
Contributor
StephanH90
left a comment
StephanH90
left a comment
There was a problem hiding this comment.
LGTM. However:
- I didn't run the code
- I didn't check the codebase for any other use of the organisation name instead of the slug which might still be broken.
You need to decide if that invalidates my approval or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.