Merged
Conversation
- Add 24 unit tests across 3 test files - Test prompts.ts: buildSystemPrompt and buildSubAgentSystemPrompt functions - Test skills.ts: formatSkillsSection function - Add bun test script to package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive test suite to address the low test coverage issue (only 2 test files vs 57 source files).
Changes
src/__tests__/prompts.test.ts- Tests for prompt building functionssrc/__tests__/skills.test.ts- Tests for skills formattingsrc/__tests__/skills_loader.test.ts- Tests for skills section formattingTest Coverage
buildSystemPrompt()- Base prompt handling, skills integrationbuildSubAgentSystemPrompt()- Sub-agent prompt buildingformatSkillsSection()- Skills XML formatting, XML escaping, multiple skillsbaseSystemPrompt- Contains expected Loki characteristicsbaseSubAgentSystemPrompt- Sub-agent role and strategyAdditional Changes
bun testscript topackage.jsonfor running testsVerification
All 24 tests pass: