support links in text-based browsers #1725
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the list template to add an additional <a> to the article header. The existing a tag uses the `entry-link` css class to make the containing article cliable by forcing `position: absolute` in combination with an empty anchor element `<a class='entry-link'></a>` This has the effect of making the entire article clickable to navigate in a graphical browser however it is not rendered in a text-based browser. To correct this the title text in the article header is wrapped in a second <a> tag. The `entry-link` css class is not applied and default css is inherited. Closes: adityatelange#1716
|
i have uploaded a screenshot of my blog using this theme with the master behavior and the behavior form this pr. This is using the EWW text browser built into Emacs to render the site with the local Hugo development server |
This change makes the titles on archive lists a tags so that they are clickable in text only mode. As with the list template, no class is applied to ensure correct indentation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the list template to add
an additional to the article header.
The existing a tag uses the
entry-linkcss classto make the containing article cliable by forcing
position: absolutein combination with an emptyanchor element
<a class='entry-link'></a>This has the effect of making the entire article
clickable to navigate in a graphical browser however
it is not rendered in a text-based browser.
To correct this the title text in the article header
is wrapped in a second tag. The
entry-linkcssclass is not applied and default css is inherited.
Closes: #1716
What does this PR change? What problem does it solve?
Was the change discussed in an issue or in the Discussions before?
PR Checklist