-
Notifications
You must be signed in to change notification settings - Fork 3
updates to individual and biospecimen templates for CLEAR-AD #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you removed the extra comma. How long was it there? Could be messing with the parsing of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, I'll add it back in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great. Once you do that, let's see if it passes the checks!
MasterPastures
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to try adding the extra comma back into nucleicAcidSource.csv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great. Once you do that, let's see if it passes the checks!
to see if it repairs the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the sage.annotations-ngs.nucleicAcidType-0.0.3 value sourced from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the sage.annotations-experimentalData.visitNumberUnit-0.0.2 value sourced from?
|
Okay, here's what went wrong here: Here's the error. The modules I am not sure what the process would be to add these to our ADKP-specific data model, but I would imagine it starts with involving the synapseAnnotations team in the RFC process. Once they create those modules in that repository, I feel confident the initial commit made here would pass all checks. |
|
relates to #160 |
to avoid dependency issues with the synapseAnnotations repo
Updated and added new terms in individual and biospecimen templates for CLEAR-AD. Refer to ADM-4405 in Jira.