Skip to content

Conversation

@ameliakallaher
Copy link
Contributor

Updated and added new terms in individual and biospecimen templates for CLEAR-AD. Refer to ADM-4405 in Jira.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you removed the extra comma. How long was it there? Could be messing with the parsing of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, I'll add it back in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, great. Once you do that, let's see if it passes the checks!

Copy link
Contributor

@MasterPastures MasterPastures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to try adding the extra comma back into nucleicAcidSource.csv.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, great. Once you do that, let's see if it passes the checks!

to see if it repairs the workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the sage.annotations-ngs.nucleicAcidType-0.0.3 value sourced from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the sage.annotations-experimentalData.visitNumberUnit-0.0.2 value sourced from?

@MasterPastures
Copy link
Contributor

Okay, here's what went wrong here:

Here's the error. The modules sage.annotations-ngs.nucleicAcidType-0.0.3 and sage.annotations-experimentalData.visitNumberUnit-0.0.2, do not exist. Here's the list of ngs modules for reference: https://github.com/Sage-Bionetworks/synapseAnnotations/tree/190546aeed148426b40bcfa9310369a0a48fc25a/terms/ngs

I am not sure what the process would be to add these to our ADKP-specific data model, but I would imagine it starts with involving the synapseAnnotations team in the RFC process. Once they create those modules in that repository, I feel confident the initial commit made here would pass all checks.

@MasterPastures
Copy link
Contributor

relates to #160

MasterPastures added a commit that referenced this pull request Mar 28, 2025
to avoid dependency issues with the synapseAnnotations repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants