added nucleicAcidType #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Suite ReportTemplate GenerationThe following manifest templates had at least one dependency with
🚧 Manifest Validation - COMING SOON |
MasterPastures
approved these changes
Apr 1, 2025
Contributor
MasterPastures
left a comment
MasterPastures
left a comment
There was a problem hiding this comment.
I confirm that I see the nucleicAcidType column and its associated values appear in the BiospecimenMetadataTemplate. Approved for merge
Contributor
|
Hi @GiaJordan -- we were able to successfully generate the manifest with the new column added, but the I already merged this PR, but do you know what we can do to ensure this action successfully runs? (our backup plan is to use data validation on a plain Excel file) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new column for nucleicAcidType for the biospecimen metadata template with valid values of "RNA, DNA, Not applicable".