Improvements to generated rust db mapping #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timbod7
commented
May 4, 2025
timbod7
commented
- Custom types for adl LocalDate, LocalTime, LocalDateTime (using time crate)
- Support for columns with generic types
- Custom types for adl LocalDate, LocalTime, LocalDateTime (using time crate) - Support for columns with generic types
alexytsu
suggested changes
Jul 25, 2025
Contributor
alexytsu
left a comment
alexytsu
left a comment
There was a problem hiding this comment.
This doesn't work as is for me.
Adding a LocalDate column to the Message struct leads to a build error in the rust code.
The generated sea-query schema (rust/adl/src/db/schema.rs) references adlgen::common::time::LocalDate while the conversions module (rust/adl/src/db/conversions.rs) references from the custom module.
Contributor
Author
|
This is backported from another project - will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.