Skip to content

Update localdatetime to zoneddatetime #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ESC8504 merged 1 commit into from
Nov 24, 2025
Merged

Update localdatetime to zoneddatetime #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/deloitte/elrr/services/dto/GoalDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.deloitte.elrr.services.dto;

import java.time.LocalDateTime;
import java.time.ZonedDateTime;
import java.util.Set;
import java.util.UUID;

Expand Down Expand Up @@ -36,11 +36,11 @@ public class GoalDto extends ExtensibleDto {
@Size(max = 65535)
private String description;

private LocalDateTime startDate;
private ZonedDateTime startDate;

private LocalDateTime achievedByDate;
private ZonedDateTime achievedByDate;

private LocalDateTime expirationDate;
private ZonedDateTime expirationDate;

private Set<UUID> competencyIds;

Expand Down
5 changes: 2 additions & 3 deletions src/test/java/com/deloitte/elrr/services/controller/GoalControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.verify;

import java.time.LocalDateTime;
import java.time.ZonedDateTime;
import java.util.ArrayList;
import java.util.HashSet;
Expand Down Expand Up @@ -373,8 +372,8 @@ private GoalDto getGoalDto() {
goalDto.setName("Test Goal");
goalDto.setDescription("Test Description");
goalDto.setType(GoalType.SELF);
goalDto.setStartDate(LocalDateTime.now());
goalDto.setAchievedByDate(LocalDateTime.now().plusMonths(6));
goalDto.setStartDate(ZonedDateTime.now());
goalDto.setAchievedByDate(ZonedDateTime.now().plusMonths(6));
goalDto.setCompetencyIds(new HashSet<>(List.of(UUID.randomUUID())));
goalDto.setCredentialIds(new HashSet<>(List.of(UUID.randomUUID())));
goalDto.setLearningResourceIds(
Expand Down
Loading