IT correctness, refactoring, remove V1 SDK#2320
Merged
Conversation
afranken
force-pushed
the
it-correctness-and-refactoring-removing-v1-sdk
branch
11 times, most recently
from
44f8398 to
e60246d
Compare
Test all ITs against S3 again to see if there are differences in behaviour, fix S3Mock if necessary. Migrate all SDK V1 tests to SDK V2. Remove SDK V1 tests. Use Lambdas where possible for functions accepting Consumer<Builder>. Kotlification.
afranken
force-pushed
the
it-correctness-and-refactoring-removing-v1-sdk
branch
from
e60246d to
546ca66
Compare
Not sure why this class was introduced in the first place...
Test all ITs against S3 again to see if there are differences in behaviour, fix S3Mock if necessary.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on cleaning up and refactoring integration tests by removing deprecated AWS SDK V1 tests and migrating all tests to AWS SDK V2 while updating test annotations and client creation patterns. Key changes include:
- Removal of all SDK V1 test files.
- Migration/refactoring of tests to use AWS SDK V2 with updated lambda DSL patterns.
- Updates of test annotations (e.g. @S3VerifiedSuccess and @S3VerifiedFailure) and copyright year adjustments.
Reviewed Changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ObjectTaggingV1IT.kt, ListObjectV1*.kt, LegalHoldV2IT.kt, BucketV1IT.kt | Removed deprecated SDK V1 tests |
| ObjectTaggingIT.kt, LegalHoldIT.kt, KotlinSDKIT.kt, CrtAsyncIT.kt, CorsIT.kt, ConcurrencyIT.kt, BucketIT.kt, AwsChunkedEndcodingIT.kt, AclIT.kt | Refactored tests to use AWS SDK V2 client creation and lambda syntax with updated annotations and year values |
| CHANGELOG.md | Updated changelog entries to reflect migration work and dependency version bumps |
Files not reviewed (1)
- integration-tests/pom.xml: Language not supported
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt
Show resolved
Hide resolved
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
N/A
Tasks