Conversation
ca3cb77 to
4ab61cb
Compare
4ab61cb to
64b84cd
Compare
c894064 to
ec0dc21
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR brings API and DTO synchronizations to align S3Mock with updated AWS S3 APIs for 2025. Key changes include updating copyright notices to 2025, adding new header converters and beans (e.g. ChecksumModeHeaderConverter and RegionConverter), and extensive modifications to endpoint signatures and integration tests to support new checksum and conditional request functionalities.
Reviewed Changes
Copilot reviewed 155 out of 155 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| S3MockProperties.java | Updated copyright year and switched to using the local dto.Region. |
| S3MockConfiguration.java | Added new beans for ChecksumMode and Region conversion. |
| S3Exception.java | Updated error message wording for INVALID_PART and added a new static method for missing checksum errors. |
| ObjectController.java | Annotated endpoints with @S3Verified and updated header handling (including checksum and conditional request parameters). |
| MultipartController.java, BucketController.java | Updated parameter naming and added conditional request support; improved test annotations. |
| Integration Tests (Kotlin) | Refactored test method names and assertions to reflect new API behaviors. |
| pom.xml, CHANGELOG.md | Updated dependency versions and changelog to document API/DTO consistency changes. |
Comments suppressed due to low confidence (2)
server/src/main/java/com/adobe/testing/s3mock/ObjectController.java:437
- Consider whether relying solely on 'if (mode == ChecksumMode.ENABLED)' is sufficient. If other valid checksum modes exist or if different behaviors are needed when disabled, document or adjust the handling accordingly.
.headers(h -> { if (mode == ChecksumMode.ENABLED) { h.setAll(checksumHeaderFrom(s3ObjectMetadata)); } })
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/MultipartIT.kt:60
- The test class was renamed from 'MultiPartIT' to 'MultipartIT'; please ensure that all references and documentation reflect this consistent naming convention.
internal class MultipartIT : S3TestBase() {
TestContainers refuses to update to a non-vulnerable version. See testcontainers/testcontainers-java#8338
This is so we can track when a function or DTO was validated against S3 APIs and is up-to-date.
Checking AWS APIs for changes and S3Mock for implementations and tests. Fixes #2340
Checking AWS APIs for changes and S3Mock for implementations and tests. Fixes #2340
Checking AWS APIs for changes and S3Mock for implementations and tests. Fixes #2340
Test ITs against S3 again to see if there are differences in behaviour, fix S3Mock if necessary. # Conflicts: # integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt
Checking AWS APIs for changes and S3Mock for implementations and tests. Fixes #2340
1355d5e to
b084188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #2340
Tasks