Skip to content

Implement bucket tagging operations (GetBucketTagging, PutBucketTagging, DeleteBucketTagging)#2977

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/implement-bucket-tagging-operations
Draft

Implement bucket tagging operations (GetBucketTagging, PutBucketTagging, DeleteBucketTagging)#2977
Copilot wants to merge 3 commits intomainfrom
copilot/implement-bucket-tagging-operations

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

Three bucket tagging API operations were listed as unsupported. This adds full support following the existing lifecycle configuration pattern.

Implementation

  • S3Exception — new NO_SUCH_TAG_SET (404), returned by GetBucketTagging when no tags exist (matches AWS; unlike object tagging, which returns an empty set)
  • BucketMetadata — new tags: List<Tag>? field with @JsonInclude(NON_NULL) for backward-compatible on-disk format; withTags() copy helper
  • BucketStorestoreBucketTagging(metadata, tags)
  • BucketServicesetBucketTagging / getBucketTagging / deleteBucketTagging
  • BucketControllerGET/PUT/DELETE /{bucketName}?tagging; NOT_TAGGING guard added to createBucket, deleteBucket, listObjects to prevent routing ambiguity

Tests

  • Controller unit tests (success + 404 error case) using backtick Kotlin style
  • Service unit test covering set → get → delete lifecycle
  • Integration tests in BucketTaggingIT: missing-tags 404, put/get, put/get/delete, tag replacement

Usage

s3Client.putBucketTagging {
    it.bucket(bucket)
    it.tagging(Tagging.builder().tagSet(Tag.builder().key("env").value("prod").build()).build())
}

s3Client.getBucketTagging { it.bucket(bucket) }.tagSet() // → [Tag(env=prod)]

s3Client.deleteBucketTagging { it.bucket(bucket) }
// subsequent getBucketTagging → NoSuchTagSet (404)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • central.sonatype.com
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher ktlint:format -pl server -Dlicense.skip=true (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true -Dtest=BucketControllerTest,BucketServiceTest (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true (dns block)
  • maven.java.net
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true -Dtest=BucketControllerTest,BucketServiceTest (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true (dns block)
  • repository.apache.org
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher ktlint:format -pl server -Dlicense.skip=true (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true -Dtest=BucketControllerTest,BucketServiceTest (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true (dns block)
  • repository.sonatype.org
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher ktlint:format -pl server -Dlicense.skip=true (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true -Dtest=BucketControllerTest,BucketServiceTest (dns block)
    • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher clean test -pl server -Dlicense.skip=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tTagging, DeleteBucketTagging)

Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
Copilot AI changed the title [WIP] Add bucket tagging operations Implement bucket tagging operations (GetBucketTagging, PutBucketTagging, DeleteBucketTagging) Feb 25, 2026
…fine CHANGELOG

Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants