-
Notifications
You must be signed in to change notification settings - Fork 193
Fix missing copyright year updates and add skill checklist reminders #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/implement-bucket-tagging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+356
−14
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
446ccb9
Initial plan
Copilot 80432af
feat: implement bucket tagging operations (GetBucketTagging, PutBucke…
Copilot 9a3f688
docs: add KDoc to new bucket tagging methods in BucketService and Buc…
Copilot 1908c77
docs: mark GetBucketTagging, PutBucketTagging, DeleteBucketTagging as…
Copilot c4bd778
chore: update copyright year to 2026 in modified test files
Copilot 7b4da2a
docs: add copyright year update step to implement, test, and refactor…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketTaggingIT.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright 2017-2026 Adobe. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.adobe.testing.s3mock.its | ||
|
|
||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.TestInfo | ||
| import software.amazon.awssdk.services.s3.S3Client | ||
| import software.amazon.awssdk.services.s3.model.Tag | ||
|
|
||
| internal class BucketTaggingIT : S3TestBase() { | ||
| private val s3Client: S3Client = createS3Client() | ||
|
|
||
| @Test | ||
| @S3VerifiedTodo | ||
| fun `GET BucketTagging returns empty tag set when no tags are set`(testInfo: TestInfo) { | ||
| val bucketName = givenBucket(testInfo) | ||
|
|
||
| val tagSet = s3Client.getBucketTagging { it.bucket(bucketName) }.tagSet() | ||
|
|
||
| assertThat(tagSet).isEmpty() | ||
| } | ||
|
|
||
| @Test | ||
| @S3VerifiedTodo | ||
| fun `PUT and GET BucketTagging succeeds`(testInfo: TestInfo) { | ||
| val bucketName = givenBucket(testInfo) | ||
| val tag1 = tag("env", "prod") | ||
| val tag2 = tag("team", "backend") | ||
|
|
||
| s3Client.putBucketTagging { | ||
| it.bucket(bucketName) | ||
| it.tagging { t -> t.tagSet(tag1, tag2) } | ||
| } | ||
|
|
||
| val tagSet = s3Client.getBucketTagging { it.bucket(bucketName) }.tagSet() | ||
|
|
||
| assertThat(tagSet).contains(tag1, tag2) | ||
| } | ||
|
|
||
| @Test | ||
| @S3VerifiedTodo | ||
| fun `PUT and GET and DELETE BucketTagging succeeds`(testInfo: TestInfo) { | ||
| val bucketName = givenBucket(testInfo) | ||
| val tag1 = tag("env", "staging") | ||
| val tag2 = tag("owner", "team-a") | ||
|
|
||
| s3Client.putBucketTagging { | ||
| it.bucket(bucketName) | ||
| it.tagging { t -> t.tagSet(tag1, tag2) } | ||
| } | ||
|
|
||
| assertThat(s3Client.getBucketTagging { it.bucket(bucketName) }.tagSet()) | ||
| .contains(tag1, tag2) | ||
|
|
||
| s3Client.deleteBucketTagging { it.bucket(bucketName) } | ||
|
|
||
| assertThat(s3Client.getBucketTagging { it.bucket(bucketName) }.tagSet()) | ||
| .isEmpty() | ||
| } | ||
|
|
||
| private fun tag( | ||
| key: String, | ||
| value: String, | ||
| ): Tag = | ||
| Tag | ||
| .builder() | ||
| .key(key) | ||
| .value(value) | ||
| .build() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setBucketTagging()persists incoming tags without validating them (e.g., max tag count, duplicate keys, disallowedaws:prefix, key/value length/charset). Object tagging already enforces these constraints viaObjectService.verifyObjectTags()and throwsS3Exception.INVALID_TAG; bucket tagging should apply the same rules to match S3 behavior and keep bucket/object tagging consistent (and add/adjust unit tests accordingly).