Skip to content

Conversation

@catheraaine
Copy link
Collaborator

@catheraaine catheraaine commented Apr 10, 2025

Summary of changes

Migrates some general use properties from Spectrum CSS.

Relevant Links

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@catheraaine catheraaine added the WIP Work in progress, likely a draft. label Apr 10, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 10, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 15:17 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 15:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 15:28 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 15:29 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 16:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 16:17 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 16:35 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 16:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 16:59 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 17:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 20:14 Inactive
@catheraaine catheraaine changed the title feat(styles): stylesheets load in expected order feat(styles): base css foundations migrated from spectrum Apr 10, 2025
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 20:21 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 20:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 10, 2025 20:55 Inactive
@catheraaine catheraaine marked this pull request as ready for review April 10, 2025 20:57
@catheraaine catheraaine requested a review from arnest00 April 10, 2025 20:57
@catheraaine catheraaine added Ready for Dev Review and removed WIP Work in progress, likely a draft. labels Apr 10, 2025
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 11, 2025 17:28 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 11, 2025 19:57 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 14, 2025 13:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 14, 2025 15:10 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 14, 2025 15:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 14, 2025 18:22 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-css-basics April 14, 2025 19:37 Inactive
Copy link
Collaborator

@arnest00 arnest00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks for working with me through this, and starting to rem the codebase up.

@catheraaine catheraaine merged commit ed8288a into main Apr 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants