feat: Blockquote #43
Merged
feat: Blockquote #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
catheraaine
changed the title
catheraaine
reviewed
Apr 18, 2025
arnest00
requested changes
Apr 21, 2025
blocks/quote/quote.js
Outdated
| @@ -1,20 +1,30 @@ | |||
| export default async function decorate(block) { | |||
| const [quotation, attribution] = [...block.children].map((c) => c.firstElementChild); | |||
| const [quotation, attribution, attributionUrl] = [...block.children].map((child) => child.firstElementChild); | |||
Collaborator
There was a problem hiding this comment.
Could we go another step further and remove the nested divs such that the final output of this block is:
<blockquote>
<p class="quote__quotation">...</p>
<p class="quote__attribution">
<cite>...</cite>
</p>
</blockquote>I moved around the structure a bit there - we can nest a <cite> within a <p> tag, but not the other way around. Let's also update the CSS class names to BEM-style naming.
blocks/quote/quote.css
Outdated
| } | ||
| margin-block-start: 0.5rem; | ||
|
|
||
| & p { |
Collaborator
There was a problem hiding this comment.
I don't think this utility class existed when you wrote this, but for the attribution text, we can give it the .util-detail-s class in quote.js!
saashapina
force-pushed
the
ADB-173-blockquote
branch
from
66bfd0e to
17fef7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
base.css*Jelly providing additional designs for attribution
Relevant Links
Test URLs:
Checklist
Validation