-
Notifications
You must be signed in to change notification settings - Fork 1
feat: filter button and filter button group #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
catheraaine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far @saashapina! Here are some suggestions.
| @@ -0,0 +1,81 @@ | |||
| /* !important added to override system styles to maintain cutoff | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we are using light text on a dark background, can we add some antialiased font-smoothing?
note you'll have to unset this just for the selected state (where it's the opposite).
Light text dark background? Antialiased.
Dark text light background? Unset.
&:has(#color-scheme option[value="dark"]:checked) {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
@media (prefers-color-scheme: dark) {
&:has(#color-scheme option[value="dark"]:checked) {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
}
| .filter-group__button--selected:hover { | ||
| background-color: light-dark(var(--spectrum-gray-800), var(--spectrum-white)); | ||
| color: light-dark(var(--spectrum-white), var(--spectrum-black)); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again you might want to test these out
Summary of changes
Relevant Links
Test URLs:
Checklist
Validation
Browser Testing
We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.
Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.
Windows
MacOS
Android
iOS