Skip to content

Conversation

@saashapina
Copy link
Collaborator

@saashapina saashapina commented Apr 21, 2025

Summary of changes

  • adds filter button and filter button group
  • adds filter button group tests

Relevant Links

Test URLs:

Checklist

  • This PR has visual changes, and has been reviewed by a designer.
  • This PR has code changes, and our linters still pass.

Validation

  1. Make sure all PR checks have passed.
  2. Pull down all related branches.
  3. Verify filter button and filter button group aligns with mockups
  4. Verify filter button active styles align with mockups
  5. Verify styles align with mockups for light, dark, and system settings on toggle
  6. Verify all tests are passing

Browser Testing

We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.

Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.

Windows

  • Firefox
  • Chrome
  • Edge

MacOS

  • Firefox
  • Chrome
  • Safari
  • Edge

Android

  • Firefox
  • Chrome
  • Edge

iOS

  • Safari

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@saashapina saashapina changed the title featAdb 174 filter button feat: Filter Button and Filter Button Group Apr 21, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 21, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to ADB-174-filter-button April 22, 2025 15:05 Inactive
Copy link
Collaborator

@catheraaine catheraaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far @saashapina! Here are some suggestions.

@@ -0,0 +1,81 @@
/* !important added to override system styles to maintain cutoff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we are using light text on a dark background, can we add some antialiased font-smoothing?

note you'll have to unset this just for the selected state (where it's the opposite).

Light text dark background? Antialiased.
Dark text light background? Unset.

&:has(#color-scheme option[value="dark"]:checked) {
  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;
}

@media (prefers-color-scheme: dark) {
  &:has(#color-scheme option[value="dark"]:checked) {
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
  }
}

.filter-group__button--selected:hover {
background-color: light-dark(var(--spectrum-gray-800), var(--spectrum-white));
color: light-dark(var(--spectrum-white), var(--spectrum-black));
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again you might want to test these out

@aem-code-sync aem-code-sync bot temporarily deployed to ADB-174-filter-button April 23, 2025 02:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ADB-174-filter-button April 24, 2025 16:15 Inactive
@catheraaine catheraaine changed the title feat: Filter Button and Filter Button Group feat: filter button and filter button group Apr 24, 2025
@saashapina saashapina merged commit 0e40f1e into main Apr 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants