-
Notifications
You must be signed in to change notification settings - Fork 1
feat: horizontal rule #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
catheraaine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I like how this is set up.
The ticket says we need to solve for both full-width and contained-width versions.
I think what I would like for us to do is make the contained-width version the default, so we can remove the 150vw css from there. This would apply for the majority of use-cases, say, blog post content.
The full-width version is used pretty rarely, but I like your solution and I want to keep it. Let's move those styles to a .horizontal-rule--full modifier class, and if we need to use them in another component we will solve that later (potentially by applying the class in the document in those few cases? this would prevent the content entry team from using the wrong one without design approval).
Should be a small change then we can merge.
Updated! I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!!
| * Converts '<hr>' and '<hr fw>' text nodes into horizontal rule elements | ||
| * @param {Element} element container element | ||
| */ | ||
| function decorateHorizontalRules(element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆, by the way.
Changes requested were implemented!
Summary of changes
Relevant Links
Test URLs:
Checklist
Validation
Browser Testing
We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.
Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.
Windows
MacOS
Android
iOS