feat: footer #51
Merged
feat: footer #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catheraaine
added
Ready for Dev Review
and removed
WIP
arnest00
reviewed
Apr 25, 2025
| skipToContentLink.innerText = "Skip to main content"; | ||
|
|
||
| return skipToContentLink; | ||
| } |
Collaborator
There was a problem hiding this comment.
This is a brilliant addition to our toolbox.
feat: footer links feat: footer copyright feat: main content has an id feat: main nav has a skip link feat: footer has bypass block feat: blocks-helpers houses helper scripts
arnest00
reviewed
Apr 29, 2025
Collaborator
arnest00
left a comment
arnest00
left a comment
There was a problem hiding this comment.
Fantastic work on this. Just one question but otherwise I think we're about ready for a rocket-shaped emoji.
| } | ||
| } | ||
|
|
||
| /* ** Typography ** */ |
Collaborator
There was a problem hiding this comment.
Thank you for labeling these sections.
| display: block; | ||
| max-width: 9.5rem; | ||
| color: var(--color-text-dark); | ||
| margin-bottom: 1rem; |
Collaborator
There was a problem hiding this comment.
Nice, covering the case if there were ever no footer-links.
blocks/footer/footer.css
Outdated
| &:has(#color-scheme option[value="dark"]:checked) { | ||
| --color-background-footer: var(--spectrum-gray-50); | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; |
Collaborator
There was a problem hiding this comment.
We've applied the anti-aliasing properties on the body element in base.css, is stating it here redundant?
arnest00
approved these changes
Apr 29, 2025
Collaborator
arnest00
left a comment
arnest00
left a comment
There was a problem hiding this comment.
Vielen dank, Catherine 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Relevant Links
Test URLs:
Validation
Review the Footer component
Review the Skip Link component
<main>element has anidand shine a blacklight on that thing to make sure it's a real ID and not one I just made in my garage and sold to the element for $15.