Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify header/footer decoration #347

Merged
merged 2 commits into from
Apr 15, 2024
Merged

chore: unify header/footer decoration #347

merged 2 commits into from
Apr 15, 2024

Conversation

fkakatie
Copy link
Member

unify decoration sequence for header and footer (same comments, same order)

fixes bug with header that previously left artifact of a stray empty div

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 12, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 12, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie requested a review from kptdobe April 15, 2024 07:47
@fkakatie fkakatie merged commit 1043b03 into main Apr 15, 2024
4 checks passed
@fkakatie fkakatie deleted the unify-head-foot branch April 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

@davidnuescheler davidnuescheler Awaiting requested review from davidnuescheler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkakatie @kptdobe