Feature/af password component #1407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Jan 2, 2025
bundles/af-core/.fbExcludeFilterFile
Outdated
| @@ -0,0 +1,41 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Why is this exclude filter file added ?
There was a problem hiding this comment.
added by mistake, removed now from the PR.
rismehta
reviewed
Jan 2, 2025
| base_file=$(git show ${{ github.base_ref }}:$file) | ||
| head_file=$(git show ${{ github.head_ref }}:$file) | ||
| # Check if the file exists in both branches | ||
| if git cat-file -e origin/${{ github.base_ref }}:$file 2>/dev/null && git cat-file -e origin/${{ github.head_ref }}:$file 2>/dev/null; then |
There was a problem hiding this comment.
These changes are already merged in dev, can you sync with latest dev ?
rismehta
reviewed
Jan 2, 2025
| @@ -35,7 +35,7 @@ | |||
| * </p> | |||
| */ | |||
|
|
|||
| @Version("5.9.6") | |||
| @Version("5.9.7") | |||
There was a problem hiding this comment.
latest version is 5.10.0, can you change it to 5.11.0 and also update java doc accordingly ?
Updated Javascript code for toggle password visibility. Html code cleanups
…ct values on view
…and min values update
* Fixing flaky test * updating quickstart docker * Fixing flaky test
Updated Javascript code for toggle password visibility. Html code cleanups
…and min values update
* Fixing flaky test * updating quickstart docker * Fixing flaky test
Updated Javascript code for toggle password visibility. Html code cleanups
…and min values update
* GH actions * Dummy change * dummy * change * Fix error * Fix error * fix error * Fix error * fix regex * Fix code * dummy change * Dummy change * Fix errors
Updated Javascript code for toggle password visibility. Html code cleanups
kum-sushil
force-pushed
the
feature/AF-Password-Component
branch
from
c10dac8 to
ffc3f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: