FORMS-16858: Support for custom XFA styles #1500

s1mahanty · 2025-01-07T07:22:47Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2025-01-07T07:41:40Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-07T07:45:24Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot · 2025-01-07T07:45:24Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot · 2025-01-07T07:45:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-07T07:47:32Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-10T07:55:25Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-10T08:00:57Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-10T08:00:57Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-10T08:01:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-10T08:01:35Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-10T08:01:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

codecov · 2025-01-10T08:04:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (3285255) to head (c4ee11f).

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1500   +/-   ##
=========================================
  Coverage     82.33%   82.33%           
  Complexity      963      963           
=========================================
  Files           107      107           
  Lines          2485     2485           
  Branches        339      339           
=========================================
  Hits           2046     2046           
  Misses          264      264           
  Partials        175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rismehta

Please add test spec for custom style in DOR. We already have a automated test which creates DOR today

…ents/core-components-it/customTemplate/custom_dor_xfa_template.xdp removing the xdp file

adobe-bot · 2025-01-12T13:32:32Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-12T13:36:27Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-12T13:36:52Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-12T13:36:52Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-12T13:37:03Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-12T13:38:09Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-12T13:38:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-12T13:41:23Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-12T13:41:23Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-12T13:41:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T02:09:53Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-13T02:11:51Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-13T02:11:51Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-13T02:12:01Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T02:14:42Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T02:14:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

...root/apps/system/config/com.adobe.granite.toggle.impl.dev.DynamicToggleProviderImpl.cfg.json

adobe-bot · 2025-01-13T10:34:02Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-13T10:39:30Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T10:40:12Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-13T10:40:12Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-13T10:40:23Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T10:40:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

...r_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/_cq_dialog/.content.xml

s1mahanty · 2025-01-15T02:18:43Z

I have added a cypress test and for the end-to-end DoR generation test, we would require the updated far.

adobe-bot · 2025-01-16T03:16:19Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-16T03:20:59Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T03:20:59Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-16T03:21:09Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T03:22:15Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T03:22:29Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T05:38:38Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-16T05:44:11Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T05:44:37Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2025-01-16T05:44:37Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T05:44:48Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T05:47:02Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

github-actions bot force-pushed the FORMS-16858 branch from 206906d to 227de77 Compare January 7, 2025 07:23

s1mahanty closed this Jan 7, 2025

s1mahanty reopened this Jan 7, 2025

rismehta requested changes Jan 10, 2025

View reviewed changes

s1mahanty added 2 commits January 12, 2025 13:11

FORMS-16858: Support for custom XFA styles

7d5badd

add cypress test

4691921

github-actions bot force-pushed the FORMS-16858 branch from 65f7f02 to 4691921 Compare January 12, 2025 13:11

delete it/content/src/main/content/jcr_root/content/dam/formsanddocum…

558af64

…ents/core-components-it/customTemplate/custom_dor_xfa_template.xdp removing the xdp file

minor fix

da7a753

iamsudhanshu reviewed Jan 13, 2025

View reviewed changes

...root/apps/system/config/com.adobe.granite.toggle.impl.dev.DynamicToggleProviderImpl.cfg.json Show resolved Hide resolved

review comments incorporated FT name update

f43045a

devgurjar reviewed Jan 14, 2025

View reviewed changes

...r_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/_cq_dialog/.content.xml Show resolved Hide resolved

adding toggle FT_FORMS-2447

c4ee11f

FORMS-16858: Support for custom XFA styles #1500

Are you sure you want to change the base?

FORMS-16858: Support for custom XFA styles #1500

Conversation

s1mahanty commented Jan 7, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented Jan 7, 2025

Accessibility Violations Found

adobe-bot commented Jan 7, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 7, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 7, 2025

Accessibility Violations Found

adobe-bot commented Jan 7, 2025

Accessibility Violations Found

adobe-bot commented Jan 10, 2025

Accessibility Violations Found

adobe-bot commented Jan 10, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 10, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 10, 2025

Accessibility Violations Found

adobe-bot commented Jan 10, 2025

Accessibility Violations Found

adobe-bot commented Jan 10, 2025

Accessibility Violations Found

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

rismehta left a comment

Choose a reason for hiding this comment

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 12, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 12, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 12, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 12, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 12, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 13, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

adobe-bot commented Jan 13, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 13, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

codecov bot commented Jan 10, 2025 •

edited

Loading