FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

s1mahanty · 2025-01-14T07:29:10Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

codecov · 2025-01-14T07:40:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (3285255) to head (8747abc).

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1505   +/-   ##
=========================================
  Coverage     82.33%   82.33%           
  Complexity      963      963           
=========================================
  Files           107      107           
  Lines          2485     2485           
  Branches        339      339           
=========================================
  Hits           2046     2046           
  Misses          264      264           
  Partials        175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2025-01-14T07:49:51Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-14T07:55:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-14T07:56:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

adobe-bot · 2025-01-15T00:12:01Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-15T00:15:48Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-15T00:15:48Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-15T00:15:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:16:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:17:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:18:23Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-15T00:21:36Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-15T00:21:36Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-15T00:21:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:22:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:23:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:24:20Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

rismehta

check comments

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

rismehta · 2025-01-16T06:56:12Z

As discussed, closing this. Let's fix the original issue.

adobe-bot · 2025-01-17T04:38:08Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T04:44:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T04:44:31Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2025-01-17T04:44:31Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T04:44:42Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

iamsudhanshu · 2025-01-17T06:13:30Z

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

+
+                if (!absoluteUrlPattern.test(url)) {
+                    return Granite.I18n.getMessage(
+                        "Enter a valid URL for the POST request. Ensure the URL starts with 'https://' or 'http://' and follows this structure: https://www.server.com/path/to/resource"


Is this reviewed by doc team?
For translation - @rismehta we need this in i18n repo ?

Yes, Khushwant has provide the string and it has been reviewed by him.

adobe-bot · 2025-01-17T13:17:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T13:17:21Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-17T13:18:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T13:30:12Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T13:35:29Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T13:35:29Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-17T13:35:35Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-17T13:35:40Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T13:36:39Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:24:04Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T14:28:32Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T14:28:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-17T14:29:00Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:29:39Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T14:29:39Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-17T14:29:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:33:04Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-17T14:33:14Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T14:33:14Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-17T14:33:25Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:36:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:38:35Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T14:43:39Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:43:40Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T14:43:40Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-17T14:43:51Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T14:44:00Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

barshat7 reviewed Jan 14, 2025

View reviewed changes

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js Outdated Show resolved Hide resolved

s1mahanty marked this pull request as ready for review January 15, 2025 00:04

rismehta requested changes Jan 15, 2025

View reviewed changes

rismehta closed this Jan 16, 2025

s1mahanty reopened this Jan 17, 2025

github-actions bot force-pushed the FORMS-16007 branch from b919fbf to 1a232d6 Compare January 17, 2025 04:20

iamsudhanshu reviewed Jan 17, 2025

View reviewed changes

Shrikha . added 3 commits January 17, 2025 19:32

minor fix

00a724d

minor fix

6023edd

minor fix

f30463a

FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

Are you sure you want to change the base?

FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

Conversation

s1mahanty commented Jan 14, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov bot commented Jan 14, 2025

Codecov Report

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 15, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 15, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

rismehta commented Jan 16, 2025

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 17, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

iamsudhanshu Jan 17, 2025

Choose a reason for hiding this comment

s1mahanty Jan 17, 2025

Choose a reason for hiding this comment

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 17, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025