FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

s1mahanty · 2025-01-14T07:29:10Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

codecov · 2025-01-14T07:40:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (07639b3) to head (ce9644b).
Report is 17 commits behind head on dev.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1505      +/-   ##
============================================
+ Coverage     82.33%   82.36%   +0.03%     
- Complexity      963      969       +6     
============================================
  Files           107      107              
  Lines          2485     2495      +10     
  Branches        339      343       +4     
============================================
+ Hits           2046     2055       +9     
+ Misses          264      262       -2     
- Partials        175      178       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2025-01-14T07:49:51Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-14T07:55:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-14T07:56:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

adobe-bot · 2025-01-15T00:12:01Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-15T00:15:48Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-15T00:15:48Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-15T00:15:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:16:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:17:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:18:23Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-15T00:21:36Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-15T00:21:36Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-15T00:21:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:22:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:23:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-15T00:24:20Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

rismehta

check comments

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

rismehta · 2025-01-16T06:56:12Z

As discussed, closing this. Let's fix the original issue.

adobe-bot · 2025-01-17T04:38:08Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-17T04:44:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-17T04:44:31Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2025-01-17T04:44:31Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-17T04:44:42Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

adobe-bot · 2025-02-26T10:57:32Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta · 2025-02-26T11:34:31Z

ui.tests/test-module/specs/formcontainer.cy.js

+        cy.invokeEditableAction("[data-action='CONFIGURE']");
+        cy.get('.cmp-adaptiveform-container__editdialog').contains('Submission').click({force:true});
+        cy.get(".cmp-adaptiveform-container__submitaction").children('._coral-Dropdown-trigger').click();
+        cy.get("._coral-Menu-itemLabel").contains('Submit to REST endpoint').should('be.visible').click();


Please don't make use of private coral selectors starting with underscore

Implemented

rismehta · 2025-02-26T11:37:04Z

ui.tests/test-module/specs/formcontainer.cy.js

+        cy.openEditableToolbar(sitesSelectors.overlays.overlay.component + formContainerEditPathSelector);
+        cy.invokeEditableAction("[data-action='CONFIGURE']");
+        cy.get('.cmp-adaptiveform-container__editdialog').contains('Submission').click({force:true});
+        cy.get(".cmp-adaptiveform-container__submitaction").children('._coral-Dropdown-trigger').click();


Even this makes use of private coral selector

Implemented

adobe-bot · 2025-02-26T11:53:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T12:42:38Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-02-26T12:42:38Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-02-26T12:42:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T12:44:04Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T12:46:31Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T17:01:36Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T17:01:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T17:32:24Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-02-26T17:32:25Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	96	96	75

adobe-bot · 2025-02-26T17:32:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T17:34:43Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-02-26T17:36:08Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

barshat7 reviewed Jan 14, 2025

View reviewed changes

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js Outdated Show resolved Hide resolved

s1mahanty marked this pull request as ready for review January 15, 2025 00:04

rismehta requested changes Jan 15, 2025

View reviewed changes

rismehta closed this Jan 16, 2025

s1mahanty reopened this Jan 17, 2025

github-actions bot force-pushed the FORMS-16007 branch from b919fbf to 1a232d6 Compare January 17, 2025 04:20

iamsudhanshu reviewed Jan 17, 2025

View reviewed changes

..._root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js Outdated Show resolved Hide resolved

pavi41 force-pushed the FORMS-16007 branch from eab71ff to 3c0328e Compare February 26, 2025 11:30

github-actions bot force-pushed the FORMS-16007 branch from 3c0328e to f22fdf4 Compare February 26, 2025 11:30

rismehta reviewed Feb 26, 2025

View reviewed changes

pavi41 force-pushed the FORMS-16007 branch from f22fdf4 to cc4b1d0 Compare February 26, 2025 12:20

github-actions bot force-pushed the FORMS-16007 branch from cc4b1d0 to 2a5321c Compare February 26, 2025 12:21

pavi41 force-pushed the FORMS-16007 branch from 2a5321c to bec4566 Compare February 26, 2025 16:36

github-actions bot force-pushed the FORMS-16007 branch from bec4566 to ee43142 Compare February 26, 2025 16:36

pavi41 force-pushed the FORMS-16007 branch from ee43142 to 6e94335 Compare February 26, 2025 17:07

Shrikha . and others added 4 commits February 26, 2025 17:07

restendpoint url validation

ae2137c

cypress test and incorporating the review comments

14d0d92

updating the fieldDescription

73ee2f8

removing the updatefieldDescription logic

ce9644b

github-actions bot force-pushed the FORMS-16007 branch from 6e94335 to ce9644b Compare February 26, 2025 17:07

rismehta merged commit 0e467d3 into dev Feb 27, 2025
9 checks passed

rismehta deleted the FORMS-16007 branch February 27, 2025 04:24

FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

FORMS-16007 : rest endpoint url validation, to not allow relative url #1505

Conversation

s1mahanty commented Jan 14, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 15, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 15, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

adobe-bot commented Jan 15, 2025

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

rismehta commented Jan 16, 2025

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Jan 17, 2025

Lighthouse scores (mobile)

adobe-bot commented Jan 17, 2025

Lighthouse scores (desktop)

adobe-bot commented Jan 17, 2025

Accessibility Violations Found

adobe-bot commented Feb 26, 2025

Accessibility Violations Found

rismehta Feb 26, 2025

Choose a reason for hiding this comment

pavi41 Feb 27, 2025

Choose a reason for hiding this comment

rismehta Feb 26, 2025

Choose a reason for hiding this comment

pavi41 Feb 27, 2025

Choose a reason for hiding this comment

adobe-bot commented Feb 26, 2025

Accessibility Violations Found

adobe-bot commented Feb 26, 2025

Lighthouse scores (mobile)

adobe-bot commented Feb 26, 2025

Lighthouse scores (desktop)

adobe-bot commented Feb 26, 2025

Accessibility Violations Found

adobe-bot commented Feb 26, 2025

Accessibility Violations Found

adobe-bot commented Feb 26, 2025

Accessibility Violations Found

codecov bot commented Jan 14, 2025 •

edited

Loading