Focus on first visible field in form and in navigable layouts #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-16650
branch
from
2372780 to
20ddad4
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
github-actions
bot
force-pushed
the
FORMS-16650
branch
from
70a4490 to
7bfb94b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1517 +/- ##
=========================================
Coverage 82.41% 82.41%
Complexity 968 968
=========================================
Files 107 107
Lines 2491 2491
Branches 342 342
=========================================
Hits 2053 2053
Misses 262 262
Partials 176 176 ☔ View full report in Codecov by Sentry. |
github-actions
bot
force-pushed
the
FORMS-16650
branch
from
aabb39e to
b77c7d1
Compare
Accessibility Violations Found
|
rismehta
reviewed
Feb 4, 2025
|
|
||
|
|
||
|
|
||
| const firstVisibleChild = findFirstVisibleEnabledChild(formContainer.getModel()._children) |
There was a problem hiding this comment.
Why are you using private API's ? please only use public API from the model
rismehta
reviewed
Feb 4, 2025
| @@ -225,6 +225,21 @@ | |||
| panel.classList.add(this.constructor.cssClasses.panel.expanded); | |||
| panel.classList.remove(this.constructor.cssClasses.panel.hidden); | |||
| panel.setAttribute("aria-hidden", false); | |||
|
|
|||
| if (document.activeElement === button) { | |||
There was a problem hiding this comment.
Why is this code required ? Its not clear, can you add some comments. Since this is part of common.js, this would also execute in authoring, which I don't think we need for this use-case
There was a problem hiding this comment.
We want focus on the first field when tab expands so I have integrated it in the expansion logic
rismehta
reviewed
Feb 4, 2025
ui.frontend/src/view/FormPanel.js
Outdated
|
|
||
| // ... existing code ... | ||
|
|
||
| focusToFirstVisibleField(id) { |
There was a problem hiding this comment.
Indent the code and remove the commented code.
pavi41
force-pushed
the
FORMS-16650
branch
4 times, most recently
from
b7cc690 to
3baa68b
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
github-actions
bot
force-pushed
the
FORMS-16650
branch
from
b139482 to
7fb8caa
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: