Dev master24 feb #1531
Merged
Dev master24 feb #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing sling output mappings in aemform embed component * Fixing sling output mappings in aemform embed component
* fix: resolve issue with hamburgermenu hiding the tabs list in desktop view * fix: tabs were getting hidden in desktop view * fix: tabs were getting hidden in desktop view and removed unused code * feat(hamburgerMenu): test case added * feat(hamburgerMenu): test case added and html on server side * fix: tabs were getting hidden in desktop view * feat(hamburgerMenu): test case added --------- Co-authored-by: Rajat Khurana <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1531 +/- ##
============================================
- Coverage 82.41% 82.36% -0.06%
- Complexity 968 969 +1
============================================
Files 107 107
Lines 2491 2495 +4
Branches 342 343 +1
============================================
+ Hits 2053 2055 +2
Misses 262 262
- Partials 176 178 +2 ☔ View full report in Codecov by Sentry. |
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: