Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing parallelisation and test splitting in circleci #357

Open
wants to merge 52 commits into
base: dev
Choose a base branch
from

Conversation

ravise5
Copy link
Contributor

@ravise5 ravise5 commented Nov 30, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@ravise5
Copy link
Contributor Author

ravise5 commented Nov 30, 2022

This is a POC
One concern is we are passing the glob of test files to the it-test.js script inside which we are using a shell script for starting the mvn command. So I'm not sure if parallelisation will occur.
So for time being I've limited the number of executors to be spun up to only 4.

@ravise5 ravise5 changed the title Testing parallelisation and test splitting in circleci Testing parallelisation and test splitting in circleci - [don't merge] Dec 1, 2022
@ravise5
Copy link
Contributor Author

ravise5 commented Dec 2, 2022

I've solved the problem of all tests getting executed on every newly spun up executor by passing the split test info as command line arguments to the script it-test.js and then modifying the pom.xml of ui.tests to accept these as an arguments which can be then passed to the cypress run --spec="" command.
But for some reason this command is erroring out inside the ci but working fine locally. Currently debugging this part.

@ravise5
Copy link
Contributor Author

ravise5 commented Dec 4, 2022

Things remaining to fix.

  1. The glob of test files need to be tweaked to exclude circle ci directory files.
  2. Cypress run --spec command defined in pom erroring out.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #357 (d83581b) into dev (6dbcdee) will not change coverage.
The diff coverage is n/a.

❗ Current head d83581b differs from pull request most recent head 40d8433. Consider uploading reports for the commit 40d8433 to get more accurate results

@@            Coverage Diff            @@
##                dev     #357   +/-   ##
=========================================
  Coverage     80.46%   80.46%           
  Complexity      579      579           
=========================================
  Files            80       80           
  Lines          1694     1694           
  Branches        206      206           
=========================================
  Hits           1363     1363           
  Misses          215      215           
  Partials        116      116           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ravise5 ravise5 added the draft label Jun 7, 2023
@ravise5 ravise5 changed the title Testing parallelisation and test splitting in circleci - [don't merge] Testing parallelisation and test splitting in circleci Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant