Fix Incorrect file name from Download component DownloadServlet.java

[zivkos]

Incorrect file name from Download component for "inline" asset #2751

Q	A
Fixed Issues?	#2751
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass?	Yes
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?
License	Apache License, Version 2.0

in com.adobe.cq.wcm.core.components.internal.servlets.DownloadServlet, have Change the following line:
response.setHeader(CONTENT_DISPOSITION_HEADER, "inline");
to
response.setHeader(CONTENT_DISPOSITION_HEADER, "inline; filename="" + filename + """);

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[zivkos]

Hi @vladbailescu, hope you are well. Is it possible for this PR to be review ? Many thanks
Zivko

[zivkos]

Can someone review PR please ?
@vladbailescu

[vladbailescu]

@zivkos , this change is causing a unit test to break:

DownloadServletTest.testInlineAssetDownload:88 expected: <inline> but was: <inline; filename="Download_Test_PDF.pdf">

[zivkos]

@zivkos , this change is causing a unit test to break:

DownloadServletTest.testInlineAssetDownload:88 expected: <inline> but was: <inline; filename="Download_Test_PDF.pdf">

Ok i will fix test..

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[zivkos]

@vladbailescu, test have been fix, can you please take a look ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (d8834a1) to head (874fad7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2903   +/-   ##
=========================================
  Coverage     87.14%   87.14%           
  Complexity     2697     2697           
=========================================
  Files           235      235           
  Lines          7202     7202           
  Branches       1104     1104           
=========================================
  Hits           6276     6276           
  Misses          366      366           
  Partials        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.