SITES-26450 - Accessibility Issues with AEM Core Components (Form) - WCAG 2.1 Compliance #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LSantha
commented
Jan 28, 2025
•
LSantha
commented
- implemented support for displaying validation messages in the markup by based on the HTML 5 form validation
- updated unit tests
- updated selenium tests
| Q | A |
|---|---|
| Fixed Issues? | SITES-26450 |
| Patch: Bug Fix? | |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
…WCAG 2.1 Compliance * implemented support for displaying validation messages in the markup by based on the HTML 5 form validation * updated unit tests * updated selenium tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
============================================
- Coverage 87.14% 87.14% -0.01%
- Complexity 2695 2697 +2
============================================
Files 235 235
Lines 7197 7201 +4
Branches 1103 1104 +1
============================================
+ Hits 6272 6275 +3
Misses 366 366
- Partials 559 560 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...es/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/form/TextImpl.java
Fixed
Show resolved
Hide resolved
...in/java/com/adobe/cq/wcm/core/components/it/seljup/util/components/formtext/v2/FormText.java
Fixed
Show fixed
Hide fixed
…WCAG 2.1 Compliance * updated selenium tests and documentation
…WCAG 2.1 Compliance * addressing review feedback
|
RaduADumitru
approved these changes
Jan 31, 2025
mohiaror
reviewed
Feb 20, 2025
| @@ -88,10 +95,19 @@ | |||
| event.target.setCustomValidity(this._properties.requiredMessage); | |||
| } | |||
| } | |||
| if (displayValidationMessage) { | |||
| let validationMessage = event.target.parentElement.querySelector(".cmp-form-text__validation-message"); | |||
There was a problem hiding this comment.
@LSantha This can be problematic. I just pulled in all the changes from master in my branch to create a private build and it fails in CM with error -
Errors:
--> JSC_LANGUAGE_FEATURE. This language feature is only supported for ECMASCRIPT6 mode or better: let declaration. at libs/core/wcm/components/form/text/v2/text/clientlibs/site.min.js line 99 : 12source: libs/core/wcm/components/form/text/v2/text/clientlibs/site.min.js line: 99
You can fix this by either not using let or by adding a jsProcessor for ECMASCRIPT support like 034884c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.