Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-28486 - open inline editing of a contentfragment in the new cf editor if a feature toggle is set #2916

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rbartl-pv
Copy link

Q                       A
Fixed Issues? SITES-28486
Patch: Bug Fix? Yes
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@vladbailescu vladbailescu requested a review from LSantha February 19, 2025 09:49
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (d8834a1) to head (6330090).

Files with missing lines Patch % Lines
...core/components/internal/ContentFragmentUtils.java 73.33% 2 Missing and 2 partials ⚠️
...models/v1/contentfragment/ContentFragmentImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2916      +/-   ##
============================================
- Coverage     87.14%   87.10%   -0.04%     
- Complexity     2697     2700       +3     
============================================
  Files           235      235              
  Lines          7202     7219      +17     
  Branches       1104     1107       +3     
============================================
+ Hits           6276     6288      +12     
- Misses          366      369       +3     
- Partials        560      562       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants